Changeset 27280 in vbox

Timestamp:

Mar 11, 2010 12:55:06 PM (15 years ago)

Author:

vboxsync

Message:

AsyncCompletion: Change range locks allocation from RTMemAlloc to RTMemCache

Location:

trunk/src/VBox/VMM

Files:

• PDMAsyncCompletionFileInternal.h (modified) (2 diffs)
• PDMAsyncCompletionFileNormal.cpp (modified) (7 diffs)

trunk/src/VBox/VMM/PDMAsyncCompletionFileInternal.h

@@ -34 +34 @@
 #include <iprt/list.h>
 #include <iprt/spinlock.h>
+#include <iprt/memcache.h>
 
 #include "PDMAsyncCompletionInternal.h"
@@ -153 +154 @@
     /** Flag whether at least one endpoint reached its bandwidth limit. */
     bool                                   fBwLimitReached;
+    /** Memory cache for file range locks. */
+    RTMEMCACHE                             hMemCacheRangeLocks;
     /** Critical section protecting the blocking event handling. */
     RTCRITSECT                             CritSectBlockingEvent;

trunk/src/VBox/VMM/PDMAsyncCompletionFileNormal.cpp

@@ -62 +62 @@
         if (pAioMgr->pahReqsFree)
         {
-            return VINF_SUCCESS;
+            /* Create the range lock memcache. */
+            rc = RTMemCacheCreate(&pAioMgr->hMemCacheRangeLocks, sizeof(PDMACFILERANGELOCK),
+                                  0, UINT32_MAX, NULL, NULL, NULL, 0);
+            if (RT_SUCCESS(rc))
+                return VINF_SUCCESS;
+
+            RTMemFree(pAioMgr->pahReqsFree);
         }
         else
@@ -85 +91 @@
 
     RTMemFree(pAioMgr->pahReqsFree);
+    RTMemCacheDestroy(pAioMgr->hMemCacheRangeLocks);
 }
 
@@ -511 +518 @@
 }
 
-static int pdmacFileAioMgrNormalRangeLock(PPDMASYNCCOMPLETIONENDPOINTFILE pEndpoint,
+static int pdmacFileAioMgrNormalRangeLock(PPDMACEPFILEMGR pAioMgr,
+                                          PPDMASYNCCOMPLETIONENDPOINTFILE pEndpoint,
                                           RTFOFF offStart, size_t cbRange,
                                           PPDMACTASKFILE pTask)
@@ -519 +527 @@
                offStart, cbRange));
 
-    PPDMACFILERANGELOCK pRangeLock = (PPDMACFILERANGELOCK)RTMemAllocZ(sizeof(PDMACFILERANGELOCK));
+    PPDMACFILERANGELOCK pRangeLock = (PPDMACFILERANGELOCK)RTMemCacheAlloc(pAioMgr->hMemCacheRangeLocks);
     if (!pRangeLock)
         return VERR_NO_MEMORY;
@@ -549 +557 @@
     RTAvlrFileOffsetRemove(pEndpoint->AioMgr.pTreeRangesLocked, pRangeLock->Core.Key);
     pTasksWaitingHead = pRangeLock->pWaitingTasksHead;
-    RTMemFree(pRangeLock);
+    RTMemCacheFree(pAioMgr->hMemCacheRangeLocks, pRangeLock);
 
     return pdmacFileAioMgrNormalProcessTaskList(pTasksWaitingHead, pAioMgr, pEndpoint);
@@ -595 +603 @@
      * which checks whether a range is already used will add the task)
      *
-     * This is neccessary because of the requirementto align all requests to a 512 boundary
+     * This is neccessary because of the requirement to align all requests to a 512 boundary
      * which is enforced by the host OS (Linux and Windows atm). It is possible that
      * we have to process unaligned tasks and need to align them using bounce buffers.
-     * While the data is feteched from the file another request might arrive writing to
+     * While the data is fetched from the file another request might arrive writing to
      * the same range. This will result in data corruption if both are executed concurrently.
      */
@@ -671 +679 @@
             AssertRC(rc);
 
-            rc = pdmacFileAioMgrNormalRangeLock(pEndpoint, offStart, cbToTransfer, pTask);
+            rc = pdmacFileAioMgrNormalRangeLock(pAioMgr, pEndpoint, offStart, cbToTransfer, pTask);
 
             if (RT_SUCCESS(rc))