Changeset 27312 in vbox for trunk/src/VBox/Runtime

Timestamp:

Mar 12, 2010 2:24:03 AM (15 years ago)

Author:

vboxsync

Message:

pipe-posix.cpp: Fixed missing VERR_NO_MEMORY in RTPipeCreate.

File:

• trunk/src/VBox/Runtime/r3/posix/pipe-posix.cpp (modified) (2 diffs)

trunk/src/VBox/Runtime/r3/posix/pipe-posix.cpp

@@ -113 +113 @@
     if (RT_SUCCESS(rc))
     {
-       /*
-        * Create the two handles.
-        */
-       RTPIPEINTERNAL *pThisR = (RTPIPEINTERNAL *)RTMemAlloc(sizeof(RTPIPEINTERNAL));
-       if (pThisR)
-       {
-           RTPIPEINTERNAL *pThisW = (RTPIPEINTERNAL *)RTMemAlloc(sizeof(RTPIPEINTERNAL));
-           if (pThisW)
-           {
-               pThisR->u32Magic = RTPIPE_MAGIC;
-               pThisW->u32Magic = RTPIPE_MAGIC;
-               pThisR->fd       = aFds[0];
-               pThisW->fd       = aFds[1];
-               pThisR->fRead    = true;
-               pThisW->fRead    = false;
-               pThisR->u32State = RTPIPE_POSIX_BLOCKING;
-               pThisW->u32State = RTPIPE_POSIX_BLOCKING;
-
-               *phPipeRead  = pThisR;
-               *phPipeWrite = pThisW;
-
-               /*
-                * Before we leave, make sure to shut up SIGPIPE.
-                */
-               signal(SIGPIPE, SIG_IGN);
-               return VINF_SUCCESS;
-           }
-
-           RTMemFree(pThisR);
-       }
+        /*
+         * Create the two handles.
+         */
+        RTPIPEINTERNAL *pThisR = (RTPIPEINTERNAL *)RTMemAlloc(sizeof(RTPIPEINTERNAL));
+        if (pThisR)
+        {
+            RTPIPEINTERNAL *pThisW = (RTPIPEINTERNAL *)RTMemAlloc(sizeof(RTPIPEINTERNAL));
+            if (pThisW)
+            {
+                pThisR->u32Magic = RTPIPE_MAGIC;
+                pThisW->u32Magic = RTPIPE_MAGIC;
+                pThisR->fd       = aFds[0];
+                pThisW->fd       = aFds[1];
+                pThisR->fRead    = true;
+                pThisW->fRead    = false;
+                pThisR->u32State = RTPIPE_POSIX_BLOCKING;
+                pThisW->u32State = RTPIPE_POSIX_BLOCKING;
+
+                *phPipeRead  = pThisR;
+                *phPipeWrite = pThisW;
+
+                /*
+                 * Before we leave, make sure to shut up SIGPIPE.
+                 */
+                signal(SIGPIPE, SIG_IGN);
+                return VINF_SUCCESS;
+            }
+
+            RTMemFree(pThisR);
+            rc = VERR_NO_MEMORY;
+        }
+        else
+            rc = VERR_NO_MEMORY;
     }
 
@@ -433 +436 @@
             else if (errno == EAGAIN)
             {
-                *pcbWritten = 0;;
+                *pcbWritten = 0;
                 rc = VINF_TRY_AGAIN;
             }