Changeset 27326 in vbox for trunk/src/VBox/Devices/PC

Timestamp:

Mar 12, 2010 12:34:40 PM (15 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

58748

Message:

DrvACPI: Avoid poking the thread since it'll cause a default gdb config to stop the guest every time one pauses or powers down the VM.

File:

• trunk/src/VBox/Devices/PC/DrvACPI.cpp (modified) (5 diffs)

trunk/src/VBox/Devices/PC/DrvACPI.cpp

@@ -84 +84 @@
     /** true = one or more batteries preset, false = no battery present. */
     bool                fBatteryPresent;
+    /** No need to RTThreadPoke the poller when set.  */
+    bool volatile       fDontPokePoller;
     /** Remaining battery capacity. */
     PDMACPIBATCAPACITY  enmBatteryRemainingCapacity;
@@ -521 +523 @@
     while (pThread->enmState == PDMTHREADSTATE_RUNNING)
     {
+        ASMAtomicWriteBool(&pThis->fDontPokePoller, false);
+
         /*
          * Read the status of the powerline-adapter.
@@ -766 +770 @@
                                                       * PDM_ACPI_BAT_CAPACITY_MAX);
             pThis->u32BatteryPresentRate =
-                                 (uint32_t)((  (float)presentRateTotal 
+                                 (uint32_t)((  (float)presentRateTotal
                                              / (float)maxCapacityTotal) * 1000);
         }
@@ -772 +776 @@
 
         /* wait a bit (e.g. Ubuntu/GNOME polls every 30 seconds) */
+        ASMAtomicWriteBool(&pThis->fDontPokePoller, true);
         rc = RTSemEventWait(pThis->hPollerSleepEvent, 20000);
     }
@@ -783 +788 @@
 
     RTSemEventSignal(pThis->hPollerSleepEvent);
-    RTThreadPoke(pThread->Thread);
+    if (!ASMAtomicReadBool(&pThis->fDontPokePoller))
+        RTThreadPoke(pThread->Thread);
     return VINF_SUCCESS;
 }