Changeset 27441 in vbox

Timestamp:

Mar 17, 2010 12:37:53 PM (15 years ago)

Author:

vboxsync

Message:

NAT: check minimal size of ICMP header before type check.

File:

• trunk/src/VBox/Devices/Network/slirp/socket.c (modified) (1 diff)

trunk/src/VBox/Devices/Network/slirp/socket.c

@@ -1057 +1057 @@
     ip = (struct ip *)buff;
     hlen = (ip->ip_hl << 2);
+    if (RT_N2H_U16(ip->ip_len) < hlen + ICMP_MINLEN)
+    {
+        Log(("send_icmp_to_guest: ICMP header is too small to understand which type/subtype of the datagram\n"));
+       return; 
+    }
     icp = (struct icmp *)((char *)ip + hlen);