Changeset 27443 in vbox for trunk/src/VBox/Devices/Network

Timestamp:

Mar 17, 2010 12:51:59 PM (15 years ago)

Author:

vboxsync

Message:

NAT: paranoid check of mbuf incrementation.

File:

• trunk/src/VBox/Devices/Network/slirp/socket.c (modified) (2 diffs)

trunk/src/VBox/Devices/Network/slirp/socket.c

@@ -1059 +1059 @@
     if (RT_N2H_U16(ip->ip_len) < hlen + ICMP_MINLEN)
     {
-        Log(("send_icmp_to_guest: ICMP header is too small to understand which type/subtype of the datagram\n"));
+       Log(("send_icmp_to_guest: ICMP header is too small to understand which type/subtype of the datagram\n"));
        return; 
     }
@@ -1137 +1137 @@
     else 
     {
+        int size = m->m_size;
         m_inc(m, len); /*increase the room of the mbuf up to len*/
+        if (size == m->m_size)
+        {
+            Log(("send_icmp_to_guest: extending buffer was failed (packet is dropped)\n"));
+            return;
+        }
         memcpy(m->m_data + original_hlen, buff + hlen, len - hlen);
     }