Changeset 27467 in vbox for trunk/src/VBox

Timestamp:

Mar 18, 2010 7:10:10 AM (15 years ago)

Author:

vboxsync

Message:

NAT: comment to ICMP find routine.

File:

• trunk/src/VBox/Devices/Network/slirp/ip_icmp.c (modified) (1 diff)

trunk/src/VBox/Devices/Network/slirp/ip_icmp.c

@@ -188 +188 @@
                 }
                 icp0 = (struct icmp *)((char *)ip0 + (ip0->ip_hl << 2));
+                /* 
+                 * IP could pointer to ICMP_REPLY datagram (1) 
+                 * or pointer IP header in ICMP payload in case of 
+                 * ICMP_TIMXCEED or ICMP_UNREACH (2)
+                 * 
+                 * if (1) and then ICMP (type should be ICMP_ECHOREPLY) and we need check that
+                 * IP.IP_SRC == IP0.IP_DST received datagramm comes from destination.
+                 *
+                 * if (2) then check that payload ICMP has got type ICMP_ECHO and 
+                 * IP.IP_DST == IP0.IP_DST destination of returned datagram is the same as
+                 * one was sent.
+                 */
                 if (  (   (icp->icmp_type != ICMP_ECHO && ip->ip_src.s_addr == ip0->ip_dst.s_addr)
                        || (icp->icmp_type == ICMP_ECHO && ip->ip_dst.s_addr == ip0->ip_dst.s_addr))