Changeset 27468 in vbox for trunk/src/VBox/Devices/Network

Timestamp:

Mar 18, 2010 7:27:01 AM (15 years ago)

Author:

vboxsync

Message:

NAT: clarification to byte order in ip_len check of original ip packet.

File:

• trunk/src/VBox/Devices/Network/slirp/socket.c (modified) (2 diffs)

trunk/src/VBox/Devices/Network/slirp/socket.c

@@ -1126 +1126 @@
             return;
         }
-#if 0
-        /* 
-         * @todo ip0 seems have different byte order on different OSes, e.g. on Solaris it's required
-         * to N2H, but on Linux no convertaion required.
+        /*
+         * while combining buffer to send (see ip_icmp.c) we control ICMP header only, 
+         * IP header combined by OS network stack, our local copy of IP header contians values 
+         * in host byte order so no byte order conversion is required. IP headers fields are converting
+         * in ip_output0 routine only.   
          */
         if (   (ip->ip_len - hlen )
@@ -1138 +1139 @@
             return;
         }
-#endif
     }