Changeset 27525 in vbox for trunk/src/VBox/Devices

Timestamp:

Mar 19, 2010 11:29:06 AM (15 years ago)

Author:

vboxsync

Message:

VMDK: Only update the modification UUID if it changed from the previous value. Avoids a lot of unneccessary 1-byte writes during VDFlush

File:

• trunk/src/VBox/Devices/Storage/VmdkHDDCore.cpp (modified) (1 diff)

trunk/src/VBox/Devices/Storage/VmdkHDDCore.cpp

@@ -5637 +5637 @@
         if (!(pImage->uOpenFlags & VD_OPEN_FLAGS_READONLY))
         {
-            pImage->ModificationUuid = *pUuid;
-            rc = vmdkDescDDBSetUuid(pImage, &pImage->Descriptor,
-                                    VMDK_DDB_MODIFICATION_UUID, pUuid);
-            if (RT_FAILURE(rc))
-                return vmdkError(pImage, rc, RT_SRC_POS, N_("VMDK: error storing modification UUID in descriptor in '%s'"), pImage->pszFilename);
+            /*
+             * Only change the modification uuid if it changed.
+             * Avoids a lot of unneccessary 1-byte writes during
+             * vmdkFlush.
+             */
+            if (RTUuidCompare(&pImage->ModificationUuid, pUuid))
+            {
+                pImage->ModificationUuid = *pUuid;
+                rc = vmdkDescDDBSetUuid(pImage, &pImage->Descriptor,
+                                        VMDK_DDB_MODIFICATION_UUID, pUuid);
+                if (RT_FAILURE(rc))
+                    return vmdkError(pImage, rc, RT_SRC_POS, N_("VMDK: error storing modification UUID in descriptor in '%s'"), pImage->pszFilename);
+            }
             rc = VINF_SUCCESS;
         }