Changeset 2754 in kBuild for trunk/src/kmk/commands.c

Timestamp:

Jan 23, 2015 11:00:41 PM (10 years ago)

Author:

bird

Message:

kmk: Save 20+ MB of memory for chopped receipt command lines by freeing them after we're done evaluating a target.

File:

• trunk/src/kmk/commands.c (modified) (2 diffs)

trunk/src/kmk/commands.c

@@ -633 +633 @@
 
 
-#ifdef KMK
+#ifdef CONFIG_WITH_MEMORY_OPTIMIZATIONS
 /* This is for saving memory in func_commands. */
 void
 free_chopped_commands (struct commands *cmds)
 {
-  if (cmds && cmds->command_lines != 0)
+  if (   cmds
+      && cmds->command_lines != 0
+      && cmds->refs == 0)
     {
       unsigned idx = cmds->ncommand_lines;
@@ -645 +647 @@
       free (cmds->command_lines);
       free (cmds->lines_flags);
-      cmds->command_lines = NULL;
-      cmds->lines_flags = NULL;
-    }
-}
-
-
-#endif /* CONFIG_WITH_COMMANDS_FUNC */
+      cmds->command_lines = 0;
+      cmds->lines_flags = 0;
+      cmds->ncommand_lines = 0;
+    }
+}
+
+
+#endif /* CONFIG_WITH_MEMORY_OPTIMIZATIONS */
 /* Execute the commands to remake FILE.  If they are currently executing,
    return or have already finished executing, just return.  Otherwise,