Changeset 27660 in vbox for trunk/src

Timestamp:

Mar 24, 2010 11:01:01 AM (15 years ago)

Author:

vboxsync

Message:

BusLogic: Update the sense data only for a CHECK_CONDITION return code

File:

• trunk/src/VBox/Devices/Storage/DevBusLogic.cpp (modified) (4 diffs)

trunk/src/VBox/Devices/Storage/DevBusLogic.cpp

@@ -1208 +1208 @@
  * @returns nothing.
  * @param   pTaskState   Pointer to the task state.
- */
-static void buslogicSenseBufferFree(PBUSLOGICTASKSTATE pTaskState)
+ * @param   fCopy        If sense data should be copied to guest memory.
+ */
+static void buslogicSenseBufferFree(PBUSLOGICTASKSTATE pTaskState, bool fCopy)
 {
     PPDMDEVINS pDevIns = pTaskState->CTX_SUFF(pTargetDevice)->CTX_SUFF(pBusLogic)->CTX_SUFF(pDevIns);
@@ -1216 +1217 @@
 
     /* Copy into guest memory. */
-    PDMDevHlpPhysWrite(pDevIns, GCPhysAddrSenseBuffer, pTaskState->pbSenseBuffer, cbSenseBuffer);
+    if (fCopy)
+        PDMDevHlpPhysWrite(pDevIns, GCPhysAddrSenseBuffer, pTaskState->pbSenseBuffer, cbSenseBuffer);
 
     RTMemFree(pTaskState->pbSenseBuffer);
@@ -1978 +1980 @@
 
         if (pTaskState->pbSenseBuffer)
-            buslogicSenseBufferFree(pTaskState);
+            buslogicSenseBufferFree(pTaskState, (rcCompletion != SCSI_STATUS_OK));
 
         buslogicSendIncomingMailbox(pBusLogic, pTaskState,
@@ -2069 +2071 @@
 
             if (pTaskState->pbSenseBuffer)
-                buslogicSenseBufferFree(pTaskState);
+                buslogicSenseBufferFree(pTaskState, true);
 
             buslogicSendIncomingMailbox(pBusLogic, pTaskState,