Changeset 2772 in kBuild for trunk/src

Timestamp:

Feb 1, 2015 8:53:48 PM (10 years ago)

Author:

bird

Message:

Elimiated a few 'return 0' and unnecessary if (rc != 0) following them.

File:

• trunk/src/kmk/kmk_cc_exec.c (modified) (15 diffs)

trunk/src/kmk/kmk_cc_exec.c

@@ -746 +746 @@
  * Emits a kKmkCcExpInstr_Return.
  *
- * @returns 0 on success, non-zero on failure.
  * @param   ppBlockTail         Pointer to the allocator tail pointer.
  */
-static int kmk_cc_exp_emit_return(PKMKCCBLOCK *ppBlockTail)
+static void kmk_cc_exp_emit_return(PKMKCCBLOCK *ppBlockTail)
 {
     PKMKCCEXPCORE pCore = kmk_cc_block_alloc_exp(ppBlockTail, sizeof(*pCore));
     pCore->enmOpCode = kKmkCcExpInstr_Return;
-    return 0;
 }
 
@@ -912 +910 @@
  * @param   cMaxArgs        Maximum number of arguments the function takes.
  */
-static int kmk_cc_exp_emit_plain_function(PKMKCCBLOCK *ppBlockTail, const char *pszFunction,
-                                          const char *pchArgs, uint32_t cchArgs, uint32_t cArgs, char chOpen, char chClose,
-                                          make_function_ptr_t pfnFunction, unsigned char cMaxArgs)
+static void kmk_cc_exp_emit_plain_function(PKMKCCBLOCK *ppBlockTail, const char *pszFunction,
+                                           const char *pchArgs, uint32_t cchArgs, uint32_t cArgs, char chOpen, char chClose,
+                                           make_function_ptr_t pfnFunction, unsigned char cMaxArgs)
 {
     uint32_t iArg;
@@ -977 +975 @@
     kmk_cc_block_realign(ppBlockTail);
     pInstr->Core.pNext = (PKMKCCEXPCORE)kmk_cc_block_get_next_ptr(*ppBlockTail);
-    return 0;
 }
 
@@ -1011 +1008 @@
  * kKmkCcExpInstr_SearchAndReplacePlainVariable instruction.
  *
- * @returns 0 on success, non-zero on failure.
  * @param   ppBlockTail         Pointer to the allocator tail pointer.
  * @param   pchName             The name of the variable.  (Does not need to be
@@ -1018 +1014 @@
  *                              nothing will be emitted.
  */
-static int kmk_cc_exp_emit_plain_variable_maybe_sr(PKMKCCBLOCK *ppBlockTail, const char *pchName, uint32_t cchName)
+static void kmk_cc_exp_emit_plain_variable_maybe_sr(PKMKCCBLOCK *ppBlockTail, const char *pchName, uint32_t cchName)
 {
     if (cchName > 0)
@@ -1100 +1096 @@
         }
     }
-    return 0;
 }
 
@@ -1107 +1102 @@
  * Emits a kKmkCcExpInstr_CopyString.
  *
- * @returns 0 on success, non-zero on failure.
  * @param   ppBlockTail         Pointer to the allocator tail pointer.
  * @param   pchStr              The string to emit (ASSUMED presistent thru-out
@@ -1114 +1108 @@
  *                              will be emitted.
  */
-static int kmk_cc_exp_emit_copy_string(PKMKCCBLOCK *ppBlockTail, const char *pchStr, uint32_t cchStr)
+static void kmk_cc_exp_emit_copy_string(PKMKCCBLOCK *ppBlockTail, const char *pchStr, uint32_t cchStr)
 {
     if (cchStr > 0)
@@ -1123 +1117 @@
         pInstr->pachSrc = pchStr;
     }
-    return 0;
 }
 
@@ -1161 +1154 @@
              * (kmk_cc_exp_emit_copy_string ignore zero length strings).
              */
-            rc = kmk_cc_exp_emit_copy_string(ppBlockTail, pchStr, offDollar + cDollars / 2);
-            if (rc != 0)
-                return rc;
+            kmk_cc_exp_emit_copy_string(ppBlockTail, pchStr, offDollar + cDollars / 2);
             pchStr += offDollar + cDollars;
             cchStr -= offDollar + cDollars;
@@ -1292 +1283 @@
                             }
                             if (!fExpandArgs || cDollars == 0)
-                                rc = kmk_cc_exp_emit_plain_function(ppBlockTail, pszFunction, pchStr, cchName,
-                                                                    cArgs, chOpen, chClose, pfnFunction, cMaxArgs);
+                                kmk_cc_exp_emit_plain_function(ppBlockTail, pszFunction, pchStr, cchName,
+                                                               cArgs, chOpen, chClose, pfnFunction, cMaxArgs);
                             else
+                            {
                                 rc = kmk_cc_exp_emit_dyn_function(ppBlockTail, pszFunction, pchStr, cchName,
                                                                   cArgs, chOpen, chClose, pfnFunction, cMaxArgs);
+                                if (rc != 0)
+                                    return rc;
+                            }
                         }
                         else
@@ -1358 +1353 @@
                             }
                             if (cDollars == 0)
-                                rc = kmk_cc_exp_emit_plain_variable_maybe_sr(ppBlockTail, pchStr, cchName);
+                                kmk_cc_exp_emit_plain_variable_maybe_sr(ppBlockTail, pchStr, cchName);
                             else
+                            {
                                 rc = kmk_cc_exp_emit_dyn_variable(ppBlockTail, pchStr, cchName);
+                                if (rc != 0)
+                                    return rc;
+                            }
                         }
                         pchStr += cchName + 1;
@@ -1368 +1367 @@
                     {
                         /* Single character variable name. */
-                        rc = kmk_cc_exp_emit_plain_variable_maybe_sr(ppBlockTail, pchStr, 1);
+                        kmk_cc_exp_emit_plain_variable_maybe_sr(ppBlockTail, pchStr, 1);
                         pchStr++;
                         cchStr--;
                     }
-                    if (rc != 0)
-                        return rc;
                 }
                 else
@@ -1387 +1384 @@
              * Nothing more to expand, the remainder is a simple string copy.
              */
-            rc = kmk_cc_exp_emit_copy_string(ppBlockTail, pchStr, cchStr);
-            if (rc != 0)
-                return rc;
+            kmk_cc_exp_emit_copy_string(ppBlockTail, pchStr, cchStr);
             break;
         }
@@ -1397 +1392 @@
      * Emit final instruction.
      */
-    return kmk_cc_exp_emit_return(ppBlockTail);
+    kmk_cc_exp_emit_return(ppBlockTail);
+    return 0;
 }