Changeset 27971 in vbox

Timestamp:

Apr 2, 2010 10:51:35 PM (15 years ago)

Author:

vboxsync

Message:

VMMDevInterface.cpp: Added remark about what looks like a missing PAGE_SIZE -> 1KB unit conversion in vmmdevReportStatistics.

File:

• trunk/src/VBox/Main/VMMDevInterface.cpp (modified) (1 diff)

trunk/src/VBox/Main/VMMDevInterface.cpp

@@ -468 +468 @@
 
 
+    /** @todo r=bird: Convert from 4KB to 1KB units?
+     *        CollectorGuestHAL::getGuestMemLoad says it returns KB units to
+     *        preCollect().  I might be wrong ofc, this is convoluted code... */
     if (pGuestStats->u32StatCaps & VBOX_GUEST_STAT_PHYS_MEM_TOTAL)
         guest->SetStatistic(pGuestStats->u32CpuId, GUESTSTATTYPE_MEMTOTAL, pGuestStats->u32PhysMemTotal);