Changeset 28046 in vbox

Timestamp:

Apr 7, 2010 12:46:12 PM (15 years ago)

Author:

vboxsync

Message:

IMachine's MemoryBalloonSize property now affects running guests as well.

Location:

trunk/src/VBox/Main

Files:

• MachineImpl.cpp (modified) (2 diffs)
• idl/VirtualBox.xidl (modified) (2 diffs)

trunk/src/VBox/Main/MachineImpl.cpp

@@ -1271 +1271 @@
 }
 
-/** @todo this method should not be public */
 STDMETHODIMP Machine::COMSETTER(MemoryBalloonSize)(ULONG memoryBalloonSize)
 {
@@ -1291 +1290 @@
     mHWData.backup();
     mHWData->mMemoryBalloonSize = memoryBalloonSize;
+
+    /* Propagate the balloon change to the guest if there's an open session. */
+    if (mData->mSession.mState != SessionState_Open)
+    {
+        ComPtr<IInternalSessionControl> directControl;
+
+        int ret = getDirectControl(&directControl);
+        if (ret == S_OK)
+        {
+            ComPtr<IConsole> mConsole = NULL;
+            ComPtr<IGuest>   mGuest = NULL;
+
+            /* get the associated console; this is a remote call (!) */
+            ret = directControl->GetRemoteConsole(mConsole.asOutParam());
+            if (ret == S_OK)
+            {
+                ret = mConsole->COMGETTER(Guest)(mGuest.asOutParam());
+                if (ret == S_OK)
+                    mGuest->COMSETTER(MemoryBalloonSize)(memoryBalloonSize);
+            }
+        }
+    }
 
     return S_OK;

trunk/src/VBox/Main/idl/VirtualBox.xidl

@@ -4346 +4346 @@
 
     <attribute name="memoryBalloonSize" type="unsigned long">
-      <desc>Initial memory balloon size in megabytes.</desc>
+      <desc>Memory balloon size in megabytes.</desc>
     </attribute>
 
@@ -8415 +8415 @@
 
     <attribute name="memoryBalloonSize" type="unsigned long">
-      <desc>Guest system memory balloon size in megabytes.</desc>
+      <desc>Guest system memory balloon size in megabytes (transient property).</desc>
     </attribute>