Changeset 28087 in vbox

Timestamp:

Apr 8, 2010 12:46:03 PM (15 years ago)

Author:

vboxsync

Message:

Guest Control/HostService: No need for locking.

File:

• trunk/src/VBox/HostServices/GuestControl/service.cpp (modified) (16 diffs)

trunk/src/VBox/HostServices/GuestControl/service.cpp

@@ -36 +36 @@
 #include <iprt/cpp/autores.h>
 #include <iprt/cpp/utils.h>
-#include <iprt/critsect.h>
 #include <iprt/err.h>
 #include <iprt/mem.h>
@@ -118 +117 @@
     /** The host command list */
     HostCmdList mHostCmds;
-    RTCRITSECT critsect;
 
 public:
@@ -135 +133 @@
                                 "GuestCtrlReq");
 #endif
-        if (RT_SUCCESS(rc))
-            rc = RTCritSectInit(&critsect);
-
         if (RT_FAILURE(rc))
             throw rc;
@@ -275 +270 @@
 int Service::execBufferAllocate(PVBOXGUESTCTRPARAMBUFFER pBuf, uint32_t cParms, VBOXHGCMSVCPARM paParms[])
 {
-    RTCritSectEnter(&critsect);
-
     AssertPtr(pBuf);
     int rc = VINF_SUCCESS;
@@ -333 +326 @@
         }
     }
-    RTCritSectLeave(&critsect);
     return rc;
 }
@@ -340 +332 @@
 void Service::execBufferFree(PVBOXGUESTCTRPARAMBUFFER pBuf)
 {
-    RTCritSectEnter(&critsect);
     AssertPtr(pBuf);
     for (uint32_t i = 0; i < pBuf->uParmCount; i++)
@@ -357 +348 @@
         pBuf->uParmCount = 0;
     }
-    RTCritSectLeave(&critsect);
 }
 
@@ -363 +353 @@
 int Service::execBufferAssign(PVBOXGUESTCTRPARAMBUFFER pBuf, uint32_t cParms, VBOXHGCMSVCPARM paParms[])
 {
-    RTCritSectEnter(&critsect);
-
     AssertPtr(pBuf);
     int rc = VINF_SUCCESS;
@@ -398 +386 @@
         }
     }
-    RTCritSectLeave(&critsect);
     return rc;
 }
@@ -422 +409 @@
     int rc = VINF_SUCCESS;
 
-    /** @todo !!!!! LOCKING !!!!!!!!! */
-
     if (cParms < 2)
     {
@@ -430 +415 @@
     }
     else
-    {      
-        /* 
+    {
+        /*
          * If host command list is empty (nothing to do right now) just
          * defer the call until we got something to do (makes the client
@@ -466 +451 @@
              else
              {
-                 rc = execBufferAssign(&curCmd.parmBuf, cParms, paParms);                 
+                 rc = execBufferAssign(&curCmd.parmBuf, cParms, paParms);
                  if (RT_SUCCESS(rc))
                      mHostCmds.pop_front();
@@ -487 +472 @@
 int Service::hostNotifyGuest(GuestCall *pCall, uint32_t eFunction, uint32_t cParms, VBOXHGCMSVCPARM paParms[])
 {
-    /** @todo !!!!! LOCKING !!!!!!!!! */
-
     AssertPtr(pCall);
-    int rc = VINF_SUCCESS;    
+    int rc = VINF_SUCCESS;
 
     int rc2 = guestGetHostMsg(pCall->mHandle, pCall->mNumParms, pCall->mParms);
@@ -502 +485 @@
 int Service::hostProcessCmd(uint32_t eFunction, uint32_t cParms, VBOXHGCMSVCPARM paParms[])
 {
-    /** @todo !!!!! LOCKING !!!!!!!!! */
-
     int rc = VINF_SUCCESS;
 
@@ -549 +530 @@
             /* The guest asks the host for the next messsage to process. */
             case GUEST_GET_HOST_MSG:
-                LogFlowFunc(("GUEST_GET_HOST_MSG\n"));                
+                LogFlowFunc(("GUEST_GET_HOST_MSG\n"));
                 rc = guestGetHostMsg(callHandle, cParms, paParms);
                 break;
@@ -571 +552 @@
                 rc = VERR_NOT_IMPLEMENTED;
         }
-        /* 
-         * If current call is not deferred, call the completion function. 
+        /*
+         * If current call is not deferred, call the completion function.
          */
         if (rc != VINF_HGCM_ASYNC_EXECUTE)