Changeset 28198 in vbox for trunk/src/VBox

Timestamp:

Apr 12, 2010 12:02:48 PM (15 years ago)

Author:

vboxsync

Message:

crOpenGL: fix possible read of unallocated memory

File:

• trunk/src/VBox/HostServices/SharedOpenGL/crserverlib/server_muralfbo.c (modified) (3 diffs)

trunk/src/VBox/HostServices/SharedOpenGL/crserverlib/server_muralfbo.c

@@ -275 +275 @@
     char *pixels, *tmppixels, *pSrc, *pDst;
     GLuint uid;
-    int i, j, rowsize, rowstride, height;
+    int i, j, realrowsize, rowsize, rowstride, height;
     CRrecti rect;
     CRContext *ctx = crStateGetCurrent();
@@ -298 +298 @@
         {
             rowsize = 4*RT_ALIGN_Z(rect.x2-rect.x1, 4);
+            realrowsize = 4*(rect.x2-rect.x1);
             tmppixels = crAlloc(rowsize*(rect.y2-rect.y1));
+            
             if (!tmppixels)
             {
@@ -313 +315 @@
             for (j=0; j<height; ++j)
             {
-                crMemcpy(pDst, pSrc, rowsize);
+                crMemcpy(pDst, pSrc, realrowsize);
 
                 pSrc -= rowstride;