Changeset 28530 in vbox

Timestamp:

Apr 20, 2010 3:50:42 PM (15 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

60335

Message:

BIOS: It is a good idea to initialize variables before using them, not after.

File:

• trunk/src/VBox/Devices/PC/BIOS/scsi.c (modified) (4 diffs)

trunk/src/VBox/Devices/PC/BIOS/scsi.c

@@ -188 +188 @@
         BX_PANIC("scsi_read_sectors: device_id out of range %d\n", device_id);
 
+    ebda_seg = read_word(0x0040, 0x000E);
     // Reset count of transferred data
     write_word(ebda_seg, &EbdaData->ata.trsfsectors,0);
@@ -204 +205 @@
     write_byte(get_SS(), aCDB + 9, 0);
 
-    ebda_seg = read_word(0x0040, 0x000E);
     io_base = read_word(ebda_seg, &EbdaData->scsi.devices[device_id].io_base);
     target_id = read_byte(ebda_seg, &EbdaData->scsi.devices[device_id].target_id);
@@ -242 +242 @@
         BX_PANIC("scsi_write_sectors: device_id out of range %d\n", device_id);
 
+    ebda_seg = read_word(0x0040, 0x000E);
     // Reset count of transferred data
     write_word(ebda_seg, &EbdaData->ata.trsfsectors,0);
@@ -258 +259 @@
     write_byte(get_SS(), aCDB + 9, 0);
 
-    ebda_seg = read_word(0x0040, 0x000E);
     io_base = read_word(ebda_seg, &EbdaData->scsi.devices[device_id].io_base);
     target_id = read_byte(ebda_seg, &EbdaData->scsi.devices[device_id].target_id);