Changeset 28570 in vbox

Timestamp:

Apr 21, 2010 5:25:20 PM (15 years ago)

Author:

vboxsync

Message:

LsiLogic: Remove interrupt coalescing again because it has a negative impact on I/O performance

File:

• trunk/src/VBox/Devices/Storage/DevLsiLogicSCSI.cpp (modified) (3 diffs)

trunk/src/VBox/Devices/Storage/DevLsiLogicSCSI.cpp

@@ -577 +577 @@
 
     PDMCritSectLeave(&pLsiLogic->ReplyPostQueueCritSect);
+
+    /* Set interrupt. */
+    lsilogicSetInterrupt(pLsiLogic, LSILOGIC_REG_HOST_INTR_STATUS_REPLY_INTR);
 }
 
@@ -1972 +1975 @@
     PLSILOGICDEVICE    pLsiLogicDevice = pTaskState->pTargetDevice;
     PLSILOGICSCSI      pLsiLogic       = pLsiLogicDevice->CTX_SUFF(pLsiLogic);
-    uint32_t           cOutstanding    = 0;
-
-    cOutstanding = ASMAtomicDecU32(&pLsiLogicDevice->cOutstandingRequests);
+
+    ASMAtomicDecU32(&pLsiLogicDevice->cOutstandingRequests);
 
     if (RT_UNLIKELY(pTaskState->fBIOS))
@@ -2001 +2003 @@
 
         if (RT_LIKELY(rcCompletion == SCSI_STATUS_OK))
-        {
             lsilogicFinishContextReply(pLsiLogic, pTaskState->GuestRequest.SCSIIO.u32MessageContext);
-            if (!cOutstanding)
-                lsilogicSetInterrupt(pLsiLogic, LSILOGIC_REG_HOST_INTR_STATUS_REPLY_INTR);
-        }
         else
         {