Changeset 28764 in vbox for trunk/src/VBox/Frontends/VBoxManage

Timestamp:

Apr 26, 2010 4:12:49 PM (15 years ago)

Author:

vboxsync

Message:

Main: Introduce a per controller setting to switch to the unbuffered async I/O interface (UseNewIo). Configurable through VBoxManage, default is still buffered

Location:

trunk/src/VBox/Frontends/VBoxManage

Files:

• VBoxManageHelp.cpp (modified) (1 diff)
• VBoxManageStorageController.cpp (modified) (4 diffs)

trunk/src/VBox/Frontends/VBoxManage/VBoxManageHelp.cpp

@@ -442 +442 @@
                  "                            [--sataideemulation<1-4> <1-30>]\n"
                  "                            [--sataportcount <1-30>]\n"
+                 "                            [--iobackend Buffered|Unbuffered]\n"
                  "                            [--remove]\n"
                  "\n");

trunk/src/VBox/Frontends/VBoxManage/VBoxManageStorageController.cpp

@@ -657 +657 @@
     { "--sataportcount",    'p', RTGETOPT_REQ_UINT32 },
     { "--remove",           'r', RTGETOPT_REQ_NOTHING },
+    { "--iobackend",        'i', RTGETOPT_REQ_STRING },
 };
 
@@ -666 +667 @@
     const char       *pszBusType     = NULL;
     const char       *pszCtlType     = NULL;
+    const char       *pszIoBackend   = NULL;
     ULONG             satabootdev    = ~0U;
     ULONG             sataidedev     = ~0U;
@@ -732 +734 @@
             }
 
+            case 'i':
+            {
+                pszIoBackend = ValueUnion.psz;
+                break;
+            }
+
             default:
             {
@@ -916 +924 @@
             }
         }
+
+        if (   pszIoBackend
+            && SUCCEEDED(rc))
+        {
+                ComPtr<IStorageController> ctl;
+
+                CHECK_ERROR(machine, GetStorageControllerByName(Bstr(pszCtl), ctl.asOutParam()));
+
+                if (!RTStrICmp(pszIoBackend, "buffered"))
+                {
+                    CHECK_ERROR(ctl, COMSETTER(IoBackend)(IoBackendType_Buffered));
+                }
+                else if (!RTStrICmp(pszIoBackend, "unbuffered"))
+                {
+                    CHECK_ERROR(ctl, COMSETTER(IoBackend)(IoBackendType_Unbuffered));
+                }
+                else
+                {
+                    errorArgument("Invalid --type argument '%s'", pszIoBackend);
+                    rc = E_FAIL;
+                }
+        }
     }