Changeset 28840 in vbox

Timestamp:

Apr 27, 2010 3:35:48 PM (15 years ago)

Author:

vboxsync

Message:

Flip RW bit for EPT pages as well.

File:

• trunk/src/VBox/VMM/VMMAll/PGMAllPool.cpp (modified) (2 diffs)

trunk/src/VBox/VMM/VMMAll/PGMAllPool.cpp

@@ -3050 +3050 @@
         case PGMPOOLKIND_PAE_PT_FOR_PAE_2MB:
         case PGMPOOLKIND_PAE_PT_FOR_PHYS:
+        case PGMPOOLKIND_EPT_PT_FOR_PHYS:   /* physical mask the same as PAE; RW bit as well; be careful! */
         {
             const uint64_t  u64 = PGM_PAGE_GET_HCPHYS(pPhysPage) | X86_PTE_P;
@@ -3115 +3116 @@
 #endif
             AssertFatalMsgFailed(("cRefs=%d iFirstPresent=%d cPresent=%d u64=%RX64 poolkind=%x\n", cRefs, pPage->iFirstPresent, pPage->cPresent, u64, pPage->enmKind));
-            break;
-        }
-
-        case PGMPOOLKIND_EPT_PT_FOR_PHYS:
-        {
-            const uint64_t  u64 = PGM_PAGE_GET_HCPHYS(pPhysPage) | X86_PTE_P;
-            PEPTPT          pPT = (PEPTPT)PGMPOOL_PAGE_2_PTR(pVM, pPage);
-
-            if ((pPT->a[iPte].u & (EPT_PTE_PG_MASK | X86_PTE_P)) == u64)
-            {
-                Log4(("pgmPoolTrackFlushGCPhysPTs: i=%d pte=%RX64 cRefs=%#x\n", iPte, pPT->a[iPte], cRefs));
-                STAM_COUNTER_INC(&pPool->StatTrackFlushEntry);
-                pPT->a[iPte].u = 0;
-
-                /* Update the counter as we're removing references. */
-                Assert(pPage->cPresent);
-                Assert(pPool->cPresent);
-                pPage->cPresent--;
-                pPool->cPresent--;
-                return bRet;
-            }
-#ifdef LOG_ENABLED
-            Log(("cRefs=%d iFirstPresent=%d cPresent=%d\n", cRefs, pPage->iFirstPresent, pPage->cPresent));
-            for (unsigned i = 0; i < RT_ELEMENTS(pPT->a); i++)
-                if ((pPT->a[i].u & (EPT_PTE_PG_MASK | X86_PTE_P)) == u64)
-                {
-                    Log(("i=%d cRefs=%d\n", i, cRefs--));
-                }
-#endif
-            AssertFatalMsgFailed(("cRefs=%d iFirstPresent=%d cPresent=%d\n", cRefs, pPage->iFirstPresent, pPage->cPresent));
             break;
         }