Changeset 28956 in vbox

Timestamp:

May 2, 2010 6:20:41 PM (15 years ago)

Author:

vboxsync

Message:

Main/OVF: make vbox:Machine element more compliant with OVF standard so that vmware will accept it

File:

• trunk/src/VBox/Main/ApplianceImplExport.cpp (modified) (2 diffs)

trunk/src/VBox/Main/ApplianceImplExport.cpp

@@ -1273 +1273 @@
     // under the vbox: namespace
     xml::ElementNode *pelmVBoxMachine = pelmVirtualSystem->createChild("vbox:Machine");
+    // ovf:required="false" tells other OVF parsers that they can ignore this thing
+    pelmVBoxMachine->setAttribute("ovf:required", "false");
+    // ovf:Info element is required or VMware will bail out on the vbox:Machine element
+    pelmVBoxMachine->createChild("ovf:Info")->addContent("Complete VirtualBox machine configuration in VirtualBox format");
+
+    // create an empty machine config
     settings::MachineConfigFile *pConfig = new settings::MachineConfigFile(NULL);
 
@@ -1278 +1284 @@
     {
         AutoWriteLock machineLock(vsdescThis->m->pMachine COMMA_LOCKVAL_SRC_POS);
+        // fill the machine config
         vsdescThis->m->pMachine->copyMachineDataToSettings(*pConfig);
+        // write the machine config to the vbox:Machine element
         pConfig->buildMachineXML(*pelmVBoxMachine,
                                  settings::MachineConfigFile::BuildMachineXML_WriteVboxVersionAttribute);