Changeset 29199 in vbox for trunk/src

Timestamp:

May 7, 2010 12:04:23 PM (15 years ago)

Author:

vboxsync

Message:

FE/Qt: 4893: VM Settings / Storage page should now not silently ignore failures when attaching a new image to a VM.

File:

• trunk/src/VBox/Frontends/VirtualBox/src/settings/vm/VBoxVMSettingsHD.cpp (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/settings/vm/VBoxVMSettingsHD.cpp

@@ -1852 +1852 @@
             KDeviceType attDeviceType = mStorageModel->data (attIndex, StorageModel::R_AttDevice).value <KDeviceType>();
             QString attMediumId = mStorageModel->data (attIndex, StorageModel::R_AttMediumId).toString();
+            QString attMediumLocation = mStorageModel->data (attIndex, StorageModel::R_AttLocation).toString();
             mMachine.AttachDevice (ctrName, attStorageSlot.port, attStorageSlot.device, attDeviceType, attMediumId);
-            if (attDeviceType == KDeviceType_DVD)
-                mMachine.PassthroughDevice (ctrName, attStorageSlot.port, attStorageSlot.device,
-                                            mStorageModel->data (attIndex, StorageModel::R_AttIsPassthrough).toBool());
-            maxUsedPort = attStorageSlot.port > maxUsedPort ? attStorageSlot.port : maxUsedPort;
+            if (mMachine.isOk())
+            {
+                if (attDeviceType == KDeviceType_DVD)
+                    mMachine.PassthroughDevice (ctrName, attStorageSlot.port, attStorageSlot.device,
+                                                mStorageModel->data (attIndex, StorageModel::R_AttIsPassthrough).toBool());
+                maxUsedPort = attStorageSlot.port > maxUsedPort ? attStorageSlot.port : maxUsedPort;
+            }
+            else
+                vboxProblem().cannotAttachDevice(this, mMachine, VBoxDefs::MediumType_HardDisk, attMediumLocation,
+                                                 attStorageSlot.bus, attStorageSlot.port, attStorageSlot.device);
         }
         if (ctrBusType == KStorageBus_SATA)