Changeset 2936 in vbox for trunk/src

Timestamp:

May 30, 2007 4:13:37 PM (18 years ago)

Author:

vboxsync

Message:

FE/Qt: Don't set the Port property when creating a USB filter from the existing device, since it will make problems for most users.

Location:

trunk/src/VBox/Frontends/VirtualBox/ui

Files:

trunk/src/VBox/Frontends/VirtualBox/ui/VBoxGlobalSettingsDlg.ui.h

-              r2903
+              r2936
     filter.SetProductId (QString().sprintf ("%04hX", usb.GetProductId()));
     filter.SetRevision (QString().sprintf ("%04hX", usb.GetRevision()));
+    /* The port property depends on the host computer rather than on the USB
+     * device itself; for this reason only a few people will want to use it in
+     * the filter since the same device plugged into a different socket will
+     * not match the filter in this case.  */
+#if 0
+    /// @todo set it anyway if Alt is currently pressed
     filter.SetPort (QString().sprintf ("%04hX", usb.GetPort()));
+#endif
     filter.SetManufacturer (usb.GetManufacturer());
     filter.SetProduct (usb.GetProduct());
     filter.SetSerialNumber (usb.GetSerialNumber());
     filter.SetRemote (usb.GetRemote() ? "yes" : "no");
     filter.SetActive (true);
     addUSBFilter (filter, true);

-              r2932
+              r2936
     filter.SetProductId (QString().sprintf ("%04hX", usb.GetProductId()));
     filter.SetRevision (QString().sprintf ("%04hX", usb.GetRevision()));
+    /* The port property depends on the host computer rather than on the USB
+     * device itself; for this reason only a few people will want to use it in
+     * the filter since the same device plugged into a different socket will
+     * not match the filter in this case.  */
+#if 0
+    /// @todo set it anyway if Alt is currently pressed
     filter.SetPort (QString().sprintf ("%04hX", usb.GetPort()));
+#endif
     filter.SetManufacturer (usb.GetManufacturer());
     filter.SetProduct (usb.GetProduct());

Note: See TracChangeset for help on using the changeset viewer.