Changeset 29421 in vbox

Timestamp:

May 12, 2010 1:34:58 PM (15 years ago)

Author:

vboxsync

Message:

Main/Snapshot: some mix between fix and workaround to sensure that the VM config file is saved after a snapshot is deleted

File:

• trunk/src/VBox/Main/SnapshotImpl.cpp (modified) (1 diff)

trunk/src/VBox/Main/SnapshotImpl.cpp

@@ -2675 +2675 @@
             {
                 AutoWriteLock machineLock(this COMMA_LOCKVAL_SRC_POS);
-                saveSettings(&fNeedsSaveSettings, SaveS_InformCallbacksAnyway);
+                /// @todo r=klaus the SaveS_Force is right now a workaround,
+                // as something in saveSettings fails to detect deleted
+                // snapshots in some cases (2 child snapshots -> 1 child
+                // snapshot). Should be fixed, but don't drop SaveS_Force
+                // then, as it avoids a rather costly config equality check
+                // when we know that it is changed.
+                saveSettings(&fNeedsSaveSettings, SaveS_Force | SaveS_InformCallbacksAnyway);
             }