Changeset 29480 in vbox for trunk/src/VBox/Frontends/VBoxManage

Timestamp:

May 14, 2010 3:24:19 PM (15 years ago)

Author:

vboxsync

Message:

Main: Remove IoBackendType in StorageController and have a boolean setting fUseAsyncHostIOMgr instead; change XML settings and frontends accordingly; change VBoxManage storagectl syntax to --hostiocache on|off as well

Location:

trunk/src/VBox/Frontends/VBoxManage

Files:

• VBoxManageHelp.cpp (modified) (1 diff)
• VBoxManageStorageController.cpp (modified) (4 diffs)

trunk/src/VBox/Frontends/VBoxManage/VBoxManageHelp.cpp

@@ -447 +447 @@
                  "                            [--sataideemulation<1-4> <1-30>]\n"
                  "                            [--sataportcount <1-30>]\n"
-                 "                            [--iobackend Buffered|Unbuffered]\n"
+                 "                            [--hostiocache on|off]\n"
                  "                            [--remove]\n"
                  "\n");

trunk/src/VBox/Frontends/VBoxManage/VBoxManageStorageController.cpp

@@ -653 +653 @@
     { "--sataportcount",    'p', RTGETOPT_REQ_UINT32 },
     { "--remove",           'r', RTGETOPT_REQ_NOTHING },
-    { "--iobackend",        'i', RTGETOPT_REQ_STRING },
+    { "--hostiocache",      'i', RTGETOPT_REQ_STRING },
 };
 
@@ -663 +663 @@
     const char       *pszBusType     = NULL;
     const char       *pszCtlType     = NULL;
-    const char       *pszIoBackend   = NULL;
+    const char       *pszHostIOCache = NULL;
     ULONG             satabootdev    = ~0U;
     ULONG             sataidedev     = ~0U;
@@ -732 +732 @@
             case 'i':
             {
-                pszIoBackend = ValueUnion.psz;
+                pszHostIOCache = ValueUnion.psz;
                 break;
             }
@@ -921 +921 @@
         }
 
-        if (   pszIoBackend
+        if (   pszHostIOCache
             && SUCCEEDED(rc))
         {
-                ComPtr<IStorageController> ctl;
-
-                CHECK_ERROR(machine, GetStorageControllerByName(Bstr(pszCtl), ctl.asOutParam()));
-
-                if (!RTStrICmp(pszIoBackend, "buffered"))
-                {
-                    CHECK_ERROR(ctl, COMSETTER(IoBackend)(IoBackendType_Buffered));
-                }
-                else if (!RTStrICmp(pszIoBackend, "unbuffered"))
-                {
-                    CHECK_ERROR(ctl, COMSETTER(IoBackend)(IoBackendType_Unbuffered));
-                }
-                else
-                {
-                    errorArgument("Invalid --type argument '%s'", pszIoBackend);
-                    rc = E_FAIL;
-                }
+            ComPtr<IStorageController> ctl;
+
+            CHECK_ERROR(machine, GetStorageControllerByName(Bstr(pszCtl), ctl.asOutParam()));
+
+            if (!RTStrICmp(pszHostIOCache, "on"))
+            {
+                CHECK_ERROR(ctl, COMSETTER(UseHostIOCache)(TRUE));
+            }
+            else if (!RTStrICmp(pszHostIOCache, "off"))
+            {
+                CHECK_ERROR(ctl, COMSETTER(UseHostIOCache)(FALSE));
+            }
+            else
+            {
+                errorArgument("Invalid --hostiocache argument '%s'", pszHostIOCache);
+                rc = E_FAIL;
+            }
         }
     }