Changeset 29547 in vbox for trunk/src/VBox/Additions/common

Timestamp:

May 17, 2010 2:07:03 PM (15 years ago)

Author:

vboxsync

Message:

VBoxServiceControlExec: cosmetics

File:

• trunk/src/VBox/Additions/common/VBoxService/VBoxServiceControl.cpp (modified) (5 diffs)

trunk/src/VBox/Additions/common/VBoxService/VBoxServiceControl.cpp

@@ -115 +115 @@
     uint32_t cbEnv = sizeof(szEnv);
     uint32_t uNumEnvVars;
-    char szStdIn[_1K];
-    char szStdOut[_1K];
-    char szStdErr[_1K];
     char szUser[128];
     char szPassword[128];
@@ -174 +171 @@
         /* Let's have a look if we have a running process with PID = uPID ... */
         PVBOXSERVICECTRLTHREAD pNode;
-        bool bFound = false;
+        bool fFound = false;
         RTListForEach(&g_GuestControlExecThreads, pNode, VBOXSERVICECTRLTHREAD, Node)
         {
@@ -183 +180 @@
                 if (pData && pData->uPID == uPID)
                 {
-                    bFound = true;
+                    fFound = true;
                     break;
                 }
@@ -189 +186 @@
         }
 
-        if (bFound)
+        if (fFound)
         {
             PVBOXSERVICECTRLTHREADDATAEXEC pData = (PVBOXSERVICECTRLTHREADDATAEXEC)pNode->pvData;
             AssertPtr(pData);
 
-            uint32_t cbSize = _4K;
+            const uint32_t cbSize = _4K;
             uint32_t cbRead = cbSize;
             uint8_t *pBuf = (uint8_t*)RTMemAlloc(cbSize);
@@ -202 +199 @@
                 if (RT_SUCCESS(rc))
                 {
-                    AssertPtr(pBuf);
                     /* cbRead now contains actual size. */
                     rc = VbglR3GuestCtrlExecSendOut(u32ClientId, uContextID, uPID, 0 /* handle ID */, 0 /* flags */,