Changeset 29636 in vbox for trunk/src/VBox

Timestamp:

May 18, 2010 1:43:55 PM (15 years ago)

Author:

vboxsync

Message:

Runtime/process-posix: consume less stack during RTProcCreateEx

File:

• trunk/src/VBox/Runtime/r3/posix/process-posix.cpp (modified) (3 diffs)

trunk/src/VBox/Runtime/r3/posix/process-posix.cpp

@@ -64 +64 @@
 #include <iprt/socket.h>
 #include <iprt/string.h>
+#include <iprt/mem.h>
 #include "internal/process.h"
 
@@ -94 +95 @@
         pw->pw_passwd = spwd->sp_pwdp;
 
-    struct crypt_data data;
-    char *pszEncPasswd = crypt_r(pszPasswd, pw->pw_passwd, &data);
+    /* be reentrant */
+    struct crypt_data *data = (struct crypt_data*)RTMemTmpAllocZ(sizeof(*data));
+    char *pszEncPasswd = crypt_r(pszPasswd, pw->pw_passwd, data);
     if (strcmp(pszEncPasswd, pw->pw_passwd))
         return VERR_PERMISSION_DENIED;
+    RTMemTmpFree(data);
 
     *gid = pw->pw_gid;
     *uid = pw->pw_uid;
     return VINF_SUCCESS;
+
 #elif defined(RT_OS_SOLARIS)
     struct passwd *ppw, pw;
@@ -125 +129 @@
     *uid = ppw->pw_uid;
     return VINF_SUCCESS;
+
 #else
     return VERR_PERMISSION_DENIED;