Changeset 29672 in vbox for trunk/src/VBox

Timestamp:

May 19, 2010 10:02:49 PM (15 years ago)

Author:

vboxsync

Message:

AHCI: Count non queued async tasks too. Fixes rare crash during suspend if an async flush is still active

File:

• trunk/src/VBox/Devices/Storage/DevAHCI.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/Storage/DevAHCI.cpp

@@ -4950 +4950 @@
 #endif
 
+        ASMAtomicDecU32(&pAhciPort->uActTasksActive);
         ahciSendD2HFis(pAhciPort, pAhciPortTaskState, pAhciPortTaskState->cmdFis, true);
     }
@@ -5442 +5443 @@
             pAhciPortTaskState->enmTxDir = enmTxDir;
 
-            if (pAhciPortTaskState->fQueued)
-            {
-                ahciLog(("%s: Before increment uActTasksActive=%u\n", __FUNCTION__, pAhciPort->uActTasksActive));
-                ASMAtomicIncU32(&pAhciPort->uActTasksActive);
-                ahciLog(("%s: After increment uActTasksActive=%u\n", __FUNCTION__, pAhciPort->uActTasksActive));
-            }
+            ahciLog(("%s: Before increment uActTasksActive=%u\n", __FUNCTION__, pAhciPort->uActTasksActive));
+            ASMAtomicIncU32(&pAhciPort->uActTasksActive);
+            ahciLog(("%s: After increment uActTasksActive=%u\n", __FUNCTION__, pAhciPort->uActTasksActive));
 
             if (enmTxDir != AHCITXDIR_FLUSH)