Changeset 29685 in vbox for trunk/src/VBox/Devices

Timestamp:

May 20, 2010 11:36:28 AM (15 years ago)

Author:

vboxsync

Message:

DevE1000.cpp: Added todo about receive queue needing optimziation as it's receiving ten thousands of inserts per second during the send part of the thruput test.

File:

• trunk/src/VBox/Devices/Network/DevE1000.cpp (modified) (1 diff)

trunk/src/VBox/Devices/Network/DevE1000.cpp

@@ -2644 +2644 @@
         if (RT_SUCCESS(rc))
         {
-#ifdef IN_RING3 /** @todo bird: Use SUPSem* for this so we can signal it in ring-0 as well. (reduces latency) */
+/** @todo bird: Use SUPSem* for this so we can signal it in ring-0 as well
+ *        without requiring any context switches.  We should also check the
+ *        wait condition before bothering to queue the item as we're currently
+ *        queuing thousands of items per second here in a normal transmit
+ *        scenario.  Expect performance changes when fixing this! */
+#ifdef IN_RING3 
             /* Signal that we have more receive descriptors avalable. */
             e1kWakeupReceive(pState->CTX_SUFF(pDevIns));