Changeset 29709 in vbox for trunk/src/VBox/HostDrivers/VBoxNetFlt/solaris/VBoxNetFltBow-solaris.c

Timestamp:

May 20, 2010 5:15:39 PM (15 years ago)

Author:

vboxsync

Message:

Solaris/VBoxNetFltBow: comments, added one error code.

File:

• trunk/src/VBox/HostDrivers/VBoxNetFlt/solaris/VBoxNetFltBow-solaris.c (modified) (8 diffs)

trunk/src/VBox/HostDrivers/VBoxNetFlt/solaris/VBoxNetFltBow-solaris.c

@@ -692 +692 @@
 
 
+/**
+ * Report capabilities and MAC address to IntNet.
+ *
+ * @param   pThis           The instance.
+ * @remarks Retains the instance while doing it's job.
+ */
 LOCAL void vboxNetFltSolarisReportInfo(PVBOXNETFLTINS pThis)
 {
@@ -710 +716 @@
 
 
+/**
+ * Initialize a VNIC.
+ *
+ * @param   pThis           The instance.
+ * @param   pVNIC           Pointer to the VNIC.
+ *
+ * @returns Solaris error code (errno).
+ */
 LOCAL int vboxNetFltSolarisInitVNIC(PVBOXNETFLTINS pThis, PVBOXNETFLTVNIC pVNIC)
 {
@@ -788 +802 @@
 
 
+/**
+ * Allocate a VNIC structure.
+ *
+ * @returns An allocated VNIC structure or NULL in case of errors.
+ */
 LOCAL PVBOXNETFLTVNIC vboxNetFltSolarisAllocVNIC(void)
 {
@@ -808 +827 @@
 
 
+/**
+ * Frees an allocated VNIC.
+ *
+ * @param   pVNIC           Pointer to the VNIC.
+ */
 LOCAL void vboxNetFltSolarisFreeVNIC(PVBOXNETFLTVNIC pVNIC)
 {
@@ -816 +840 @@
 
 /**
- * Destroy a created VNIC.
- *
- * @param   pThis           The VM connection instance.
+ * Destroy a created VNIC if it was created by us, or just
+ * de-initializes the VNIC freeing up resources handles.
+ *
+ * @param   pVNIC           Pointer to the VNIC.
  */
 LOCAL void vboxNetFltSolarisDestroyVNIC(PVBOXNETFLTVNIC pVNIC)
@@ -932 +957 @@
 
         vboxNetFltSolarisDestroyVNIC(pVNIC);
-        rc = VERR_INTNET_FLT_IF_FAILED;
+        rc = VERR_OPEN_FAILED;
     }
     else
@@ -938 +963 @@
         LogRel((DEVICE_NAME ":vboxNetFltSolarisCreateVNIC failed to create VNIC '%s' over '%s' rc=%d Diag=%d\n", pVNIC->szName,
                     pThis->szName, rc, Diag));
+        rc = VERR_INTNET_FLT_VNIC_CREATE_FAILED;
     }
 
     vboxNetFltSolarisFreeVNIC(pVNIC);
 
-    return RTErrConvertFromErrno(rc);
+    return rc;
 }
 
@@ -1206 +1232 @@
         }
         else
-            LogRel((DEVICE_NAME ":vboxNetFltPortOsConnectInterface failed to create VNIC\n"));
+            LogRel((DEVICE_NAME ":vboxNetFltPortOsConnectInterface failed to create VNIC rc=%d\n", rc));
     }
     else