Changeset 29783 in vbox

Timestamp:

May 25, 2010 1:13:35 PM (15 years ago)

Author:

vboxsync

Message:

iprt: %.5RX32 ++ bug fix - precision should padd with '0' as it used to do.

Location:

trunk/src/VBox/Runtime

Files:

• common/string/strformat.cpp (modified) (2 diffs)
• testcase/tstRTStrFormat.cpp (modified) (3 diffs)

trunk/src/VBox/Runtime/common/string/strformat.cpp

@@ -273 +273 @@
      */
     while (--cchPrecision >= cchValue)
-        *psz++ = ' ';
+        *psz++ = '0';
 
     /*
@@ -352 +352 @@
  * @param   InArgs      Argument list.
  */
-RTDECL(size_t) RTStrFormatV(PFNRTSTROUTPUT pfnOutput, void *pvArgOutput, PFNSTRFORMAT pfnFormat, void *pvArgFormat, 
+RTDECL(size_t) RTStrFormatV(PFNRTSTROUTPUT pfnOutput, void *pvArgOutput, PFNSTRFORMAT pfnFormat, void *pvArgFormat,
                             const char *pszFormat, va_list InArgs)
 {

trunk/src/VBox/Runtime/testcase/tstRTStrFormat.cpp

@@ -434 +434 @@
     CHECK42("%4RU32",  (uint32_t)42, "  42");
     CHECK42("%04RU32", (uint32_t)42, "0042");
+    CHECK42("%.4RU32", (uint32_t)42, "0042");
 
     CHECK42("%RU64", (uint64_t)112345987345ULL, "112345987345");
@@ -439 +440 @@
     CHECK42("%14RU64",  (uint64_t)4, "             4");
     CHECK42("%014RU64", (uint64_t)4, "00000000000004");
+    CHECK42("%.14RU64", (uint64_t)4, "00000000000004");
 
     CHECK42("%RU8", (uint8_t)1, "1");
@@ -454 +456 @@
     CHECK42("%5RX64",   UINT64_C(0x42), "   42");
     CHECK42("%05RX64",  UINT64_C(0x42), "00042");
-    CHECK42("%.5RX64",  UINT64_C(0x42), "   42");
-    CHECK42("%.05RX64", UINT64_C(0x42), "   42");
+    CHECK42("%.5RX64",  UINT64_C(0x42), "00042");
+    CHECK42("%.05RX64", UINT64_C(0x42), "00042"); /* '0' is ignored */
 
     CHECK42("%RX8", (uint8_t)1, "1");