Changeset 29819 in vbox for trunk/src

Timestamp:

May 26, 2010 2:05:27 PM (15 years ago)

Author:

vboxsync

Message:

RTSha1Digest.cpp: Don't mix allocators! Also, check for allocation failure and use constants.

File:

• trunk/src/VBox/Runtime/common/checksum/RTSha1Digest.cpp (modified) (1 diff)

trunk/src/VBox/Runtime/common/checksum/RTSha1Digest.cpp

@@ -90 +90 @@
         return VERR_INTERNAL_ERROR;
 
-    *ppszDigest = (char*)RTMemAlloc(41);
-    rc = RTSha1ToString(auchDig, *ppszDigest, 41);
-    if (RT_FAILURE(rc))
-        RTStrFree(*ppszDigest);
+    char *pszDigest;
+    rc = RTStrAllocEx(&pszDigest, RTSHA1_DIGEST_LEN + 1);
+    if (RT_SUCCESS(rc))
+    {
+        rc = RTSha1ToString(auchDig, pszDigest, RTSHA1_DIGEST_LEN + 1);
+        if (RT_SUCCESS(rc))
+            *ppszDigest = pszDigest;
+        else
+            RTStrFree(pszDigest);
+    }
 
     return rc;