Changeset 29873 in vbox for trunk/src/VBox/Runtime/r3

Timestamp:

May 28, 2010 5:14:53 PM (15 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

62118

Message:

OVF: fix incorrect disk UUIDs in machine XML on export

File:

• trunk/src/VBox/Runtime/r3/xml.cpp (modified) (2 diffs)

trunk/src/VBox/Runtime/r3/xml.cpp

@@ -1011 +1011 @@
 AttributeNode* ElementNode::setAttribute(const char *pcszName, const char *pcszValue)
 {
+    AttributeNode *pattrReturn;
     Data::AttributesMap::const_iterator it;
 
@@ -1024 +1025 @@
         // store
         m->attribs[pcszKey] = pNew;
+        pattrReturn = pNew.get();
     }
     else
     {
-        // @todo
-        throw LogicError("Attribute exists");
-    }
-
-    return NULL;
+        // overwrite existing libxml attribute node
+        xmlAttrPtr plibAttr = xmlSetProp(m_plibNode, (xmlChar*)pcszName, (xmlChar*)pcszValue);
+
+        // and fix our existing C++ side around it
+        boost::shared_ptr<AttributeNode> pattr = it->second;
+        pattr->m_plibAttr = plibAttr;       // in case the xmlAttrPtr is different, I'm not sure
+
+        pattrReturn = pattr.get();
+    }
+
+    return pattrReturn;
 
 }