Changeset 29879 in vbox

Timestamp:

May 30, 2010 10:55:03 AM (15 years ago)

Author:

vboxsync

Message:

DevAHCI.cpp: r=bird: Using TMCLOCK_VIRTUAL_SYNC in devices which aren't time sources requires some justificiation. See DevEHCI for instance.

File:

• trunk/src/VBox/Devices/Storage/DevAHCI.cpp (modified) (1 diff)

trunk/src/VBox/Devices/Storage/DevAHCI.cpp

@@ -6894 +6894 @@
 
     /* Create the timer for command completion coalescing feature. */
+    /** @todo r=bird: Using the virtual sync clock needs some justification.
+     *        Currently not an issue as this feature isn't used by any guest
+     *        yet. */
     rc = PDMDevHlpTMTimerCreate(pDevIns, TMCLOCK_VIRTUAL_SYNC, ahciCccTimer, pThis,
                                 TMTIMER_FLAGS_DEFAULT_CRIT_SECT, "AHCI CCC Timer", &pThis->pHbaCccTimerR3);