Changeset 29940 in vbox for trunk/src

Timestamp:

Jun 1, 2010 11:09:44 AM (15 years ago)

Author:

vboxsync

Message:

Main/Medium: fix a couple of lock order violations around calling VirtualBox::saveSettings, plus eliminating some leave() method calls where release() is obviously the same thing

File:

• trunk/src/VBox/Main/MediumImpl.cpp (modified) (13 diffs)

trunk/src/VBox/Main/MediumImpl.cpp

@@ -1441 +1441 @@
     m->type = aType;
 
+    mlock.release();
+
     // saveSettings needs vbox lock
-    ComObjPtr<VirtualBox> pVirtualBox(m->pVirtualBox);
-    mlock.leave();
     AutoWriteLock alock(m->pVirtualBox COMMA_LOCKVAL_SRC_POS);
 
-    HRESULT rc = pVirtualBox->saveSettings();
+    HRESULT rc = m->pVirtualBox->saveSettings();
 
     return rc;
@@ -1559 +1559 @@
     if (FAILED(autoCaller.rc())) return autoCaller.rc();
 
-    /* VirtualBox::saveSettings() needs a write lock */
-    AutoMultiWriteLock2 alock(m->pVirtualBox, this COMMA_LOCKVAL_SRC_POS);
+    AutoWriteLock mlock(this COMMA_LOCKVAL_SRC_POS);
 
     if (m->pParent.isNull())
@@ -1570 +1569 @@
     {
         m->autoReset = !!aAutoReset;
+
+        mlock.release();
+
+        // saveSettings needs vbox lock
+        AutoWriteLock alock(m->pVirtualBox COMMA_LOCKVAL_SRC_POS);
 
         return m->pVirtualBox->saveSettings();
@@ -1980 +1984 @@
     if (FAILED(autoCaller.rc())) return autoCaller.rc();
 
-    /* VirtualBox::saveSettings() needs a write lock */
-    AutoMultiWriteLock2 alock(m->pVirtualBox, this COMMA_LOCKVAL_SRC_POS);
+    AutoWriteLock mlock(this COMMA_LOCKVAL_SRC_POS);
 
     switch (m->state)
@@ -2003 +2006 @@
         it->second = aValue;
 
+    mlock.release();
+
+    // saveSettings needs vbox lock
+    AutoWriteLock alock(m->pVirtualBox COMMA_LOCKVAL_SRC_POS);
     HRESULT rc = m->pVirtualBox->saveSettings();
 
@@ -2051 +2058 @@
     if (FAILED(autoCaller.rc())) return autoCaller.rc();
 
-    /* VirtualBox::saveSettings() needs a write lock */
-    AutoMultiWriteLock2 alock(m->pVirtualBox, this COMMA_LOCKVAL_SRC_POS);
+    AutoWriteLock mlock(this COMMA_LOCKVAL_SRC_POS);
 
     com::SafeArray<IN_BSTR> names(ComSafeArrayInArg(aNames));
@@ -2081 +2087 @@
     }
 
+    mlock.release();
+
+    // saveSettings needs vbox lock
+    AutoWriteLock alock(m->pVirtualBox COMMA_LOCKVAL_SRC_POS);
     HRESULT rc = m->pVirtualBox->saveSettings();
 
@@ -3449 +3459 @@
 
         alock.leave();
-
         vrc = RTSemEventMultiWait(m->queryInfoSem, RT_INDEFINITE_WAIT);
-
         alock.enter();
 
@@ -5161 +5169 @@
 
         /* unlock before the potentially lengthy operation */
-        thisLock.leave();
+        thisLock.release();
 
         try
@@ -5295 +5303 @@
         /* the two media are now protected by their non-default states;
          * unlock the media before the potentially lengthy operation */
-        mediaLock.leave();
+        mediaLock.release();
 
         try
@@ -5412 +5420 @@
         if (fNeedsSaveSettings)
         {
-            mediaLock.leave();
+            mediaLock.release();
             AutoWriteLock vboxlock(m->pVirtualBox COMMA_LOCKVAL_SRC_POS);
             m->pVirtualBox->saveSettings();
@@ -5817 +5825 @@
 
             /* unlock before the potentially lengthy operation */
-            thisLock.leave();
+            thisLock.release();
 
             /* ensure the target directory exists */
@@ -6238 +6246 @@
 
             /* unlock before the potentially lengthy operation */
-            thisLock.leave();
+            thisLock.release();
 
             vrc = VDCompact(hdd, VD_LAST_IMAGE, task.mVDOperationIfaces);