Changeset 29945 in vbox for trunk/src

Timestamp:

Jun 1, 2010 12:49:25 PM (15 years ago)

Author:

vboxsync

Message:

Main/Host: remove host lock from Host::GetNetworkInterfaces (the other methods which enumerate interfaces don't take it either), and leave the VirtualBox lock for the called setVirtualBox method since there is no chance of lock order violations any more

File:

• trunk/src/VBox/Main/HostImpl.cpp (modified) (1 diff)

trunk/src/VBox/Main/HostImpl.cpp

@@ -500 +500 @@
     AutoCaller autoCaller(this);
     if (FAILED(autoCaller.rc())) return autoCaller.rc();
-
-    /* The code is so hideously complicated that I can't tell whether the
-     * host object lock is really needed. It was taken here, and as the
-     * VirtualBox (mParent) is taken as well below nested deep down that
-     * would be a lock order violation. */
-    AutoMultiWriteLock2 alock(m->pParent, this COMMA_LOCKVAL_SRC_POS);
 
     std::list <ComObjPtr<HostNetworkInterface> > list;