Changeset 29976 in vbox for trunk/src

Timestamp:

Jun 2, 2010 11:25:57 AM (15 years ago)

Author:

vboxsync

Message:

HGCM: workaround for a hang (xTracker 4985).

File:

• trunk/src/VBox/Main/hgcm/HGCMThread.cpp (modified) (5 diffs)

trunk/src/VBox/Main/hgcm/HGCMThread.cpp

@@ -90 +90 @@
         /* A caller thread waits for completion of a SENT message on this event. */
         RTSEMEVENTMULTI m_eventSend;
+        int32_t volatile m_i32MessagesProcessed;
 
         /* Critical section for accessing the thread data, mostly for message queues. */
@@ -213 +214 @@
     m_eventThread (0),
     m_eventSend (0),
+    m_i32MessagesProcessed (0),
     m_fu32ThreadFlags (0),
     m_pMsgInputQueueHead (NULL),
@@ -433 +435 @@
         if (fWait)
         {
+            /* Immediately check if the message has been processed. */
             while ((pMsg->m_fu32Flags & HGCM_MSG_F_PROCESSED) == 0)
             {
-                RTSemEventMultiWait (m_eventSend, RT_INDEFINITE_WAIT);
+                /* Poll infrequently to make sure no completed message has been missed. */
+                RTSemEventMultiWait (m_eventSend, 1000);
+
+                LogFlow(("HGCMThread::MsgPost: wait completed flags = %08X\n", pMsg->m_fu32Flags));
+
+                if ((pMsg->m_fu32Flags & HGCM_MSG_F_PROCESSED) == 0)
+                {
+                    RTThreadYield();
+                }
+            }
+
+            /* 'Our' message has been processed, so should reset the semaphore.
+             * There is still possible that another message has been processed
+             * and the semaphore has been signalled again.
+             * Reset only if there are no other messages completed.
+             */
+            int32_t c = ASMAtomicDecS32(&m_i32MessagesProcessed);
+            Assert(c >= 0);
+            if (c == 0)
+            {
                 RTSemEventMultiReset (m_eventSend);
-
-                LogFlow(("HGCMThread::MsgPost: wait completed flags = %08X\n", pMsg->m_fu32Flags));
             }
 
@@ -581 +601 @@
         bool fWaited = ((pMsg->m_fu32Flags & HGCM_MSG_F_WAIT) != 0);
 
+        if (fWaited)
+        {
+            ASMAtomicIncS32(&m_i32MessagesProcessed);
+
+            /* This should be done before setting the HGCM_MSG_F_PROCESSED flag. */
+            pMsg->m_rcSend = result;
+        }
+
         /* The message is now completed. */
         pMsg->m_fu32Flags &= ~HGCM_MSG_F_IN_PROCESS;
@@ -592 +620 @@
         if (fWaited)
         {
-            /* If message is being waited, then it is referenced by the waiter and the pointer
-             * if valid even after hgcmObjDeleteHandle.
-             */
-            pMsg->m_rcSend = result;
-
             /* Wake up all waiters. so they can decide if their message has been processed. */
             RTSemEventMultiSignal (m_eventSend);