Changeset 30049 in vbox for trunk/src

Timestamp:

Jun 7, 2010 6:36:26 AM (15 years ago)

Author:

vboxsync

Message:

VBoxServiceVMInfo-win.cpp: r=bird: Consistent error handling in VBoxServiceVMInfoWinWriteUsers.

File:

• trunk/src/VBox/Additions/common/VBoxService/VBoxServiceVMInfo-win.cpp (modified) (9 diffs)

trunk/src/VBox/Additions/common/VBoxService/VBoxServiceVMInfo-win.cpp

@@ -37 +37 @@
 
 
+/*******************************************************************************
+*   Structures and Typedefs                                                    *
+*******************************************************************************/
 /** Structure for storing the looked up user information. */
 typedef struct
@@ -44 +47 @@
     WCHAR wszLogonDomain[_MAX_PATH];
 } VBOXSERVICEVMINFOUSER, *PVBOXSERVICEVMINFOUSER;
+
 /** Structure for the file information lookup. */
 typedef struct
@@ -50 +54 @@
     char *pszFileName;
 } VBOXSERVICEVMINFOFILE, *PVBOXSERVICEVMINFOFILE;
+
 /** Structure for process information lookup. */
 typedef struct
@@ -66 +71 @@
 void VBoxServiceVMInfoWinProcessesFree(PVBOXSERVICEVMINFOPROC paProcs);
 
-
-/*******************************************************************************
-*   Global Variables                                                           *
-*******************************************************************************/
 
 
@@ -406 +407 @@
                                                &cbRet))
                 {
-                    if(cbRet)
+                    if (cbRet)
                         iState = *pBuffer;
                     VBoxServiceVerbose(3, "VMInfo/Users:  Account User=%ls, WTSConnectState=%d\n",
@@ -449 +450 @@
  *
  * @returns VBox status code.
- * @param   ppszUserList    Where to store the user list (separated by commas).  Must be
- *                          freed with RTStrFree().
+ * @param   ppszUserList    Where to store the user list (separated by commas).
+ *                          Must be freed with RTStrFree().
  * @param   pcUsersInList   Where to store the number of users in the list.
  */
@@ -457 +458 @@
     PLUID       paSessions = NULL;
     ULONG       cSession = 0;
-    NTSTATUS    r = 0;
 
     /* This function can report stale or orphaned interactive logon sessions
        of already logged off users (especially in Windows 2000). */
-    r = LsaEnumerateLogonSessions(&cSession, &paSessions);
+    NTSTATUS rcNt = LsaEnumerateLogonSessions(&cSession, &paSessions);
     VBoxServiceVerbose(3, "VMInfo/Users: Found %ld users\n", cSession);
-    if (r != STATUS_SUCCESS)
-    {
-        VBoxServiceError("VMInfo/Users: LsaEnumerate failed with %lu\n", LsaNtStatusToWinError(r));
-        return RTErrConvertFromWin32(LsaNtStatusToWinError(r));
+    if (rcNt != STATUS_SUCCESS)
+    {
+        VBoxServiceError("VMInfo/Users: LsaEnumerate failed with %lu\n", LsaNtStatusToWinError(rcNt));
+        return RTErrConvertFromWin32(LsaNtStatusToWinError(rcNt));
     }
 
@@ -484 +484 @@
                 {
                     rc = RTStrAAppend(ppszUserList, ",");
-                    AssertRCReturn(rc, rc);
+                    AssertRCBreakStmt(rc, RTStrFree(*ppszUserList));
                 }
 
@@ -495 +495 @@
                     rc = RTStrAAppend(ppszUserList, pszTemp);
                     RTMemFree(pszTemp);
-                    AssertRCReturn(rc, rc);
                 }
                 else
-                    RTStrAAppend(ppszUserList, "<string-convertion-error>");
+                    rc = RTStrAAppend(ppszUserList, "<string-convertion-error>");
+                AssertRCBreakStmt(rc, RTStrFree(*ppszUserList));
             }
         }