Changeset 30111 in vbox for trunk/src/VBox/HostDrivers/Support

Timestamp:

Jun 9, 2010 12:14:59 PM (15 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

62505

Message:

iprt/asm.h,*: Revised the ASMAtomic*Ptr functions and macros. The new saves lots of unsafe (void * volatile *) casts as well as adding some type safety when using GCC (typeof rulez).

Location:

trunk/src/VBox/HostDrivers/Support

Files:

• SUPLib.cpp (modified) (1 diff)
• SUPR0IdcClient.c (modified) (3 diffs)
• SUPSvcGrant.cpp (modified) (2 diffs)

trunk/src/VBox/HostDrivers/Support/SUPLib.cpp

@@ -508 +508 @@
         if (g_pSUPGlobalInfoPage)
         {
-            ASMAtomicXchgPtr((void * volatile *)&g_pSUPGlobalInfoPage, NULL);
-            ASMAtomicXchgPtr((void * volatile *)&g_pSUPGlobalInfoPageR0, NULL);
-            ASMAtomicXchgSize(&g_HCPhysSUPGlobalInfoPage, NIL_RTHCPHYS);
+            ASMAtomicWritePtr((void * volatile *)&g_pSUPGlobalInfoPage, NULL);
+            ASMAtomicWritePtr((void * volatile *)&g_pSUPGlobalInfoPageR0, NULL);
+            ASMAtomicWriteSize(&g_HCPhysSUPGlobalInfoPage, NIL_RTHCPHYS);
             /* just a little safe guard against threads using the page. */
             RTThreadSleep(50);

trunk/src/VBox/HostDrivers/Support/SUPR0IdcClient.c

@@ -125 +125 @@
             &&  (Req.u.Out.uSessionVersion & UINT32_C(0xffff0000)) == (SUPDRV_IDC_VERSION & UINT32_C(0xffff0000)))
         {
-            ASMAtomicCmpXchgPtr((void * volatile *)&g_pMainHandle, pHandle, NULL);
+            ASMAtomicCmpXchgPtr(&g_pMainHandle, pHandle, NULL);
             return rc;
         }
@@ -167 +167 @@
     {
         pHandle->s.pSession = NULL;
-        ASMAtomicCmpXchgPtr((void * volatile *)&g_pMainHandle, NULL, pHandle);
+        ASMAtomicCmpXchgPtr(&g_pMainHandle, NULL, pHandle);
     }
     return rc;
@@ -203 +203 @@
 PSUPDRVIDCHANDLE supR0IdcGetHandleFromSession(PSUPDRVSESSION pSession)
 {
-    PSUPDRVIDCHANDLE pHandle = (PSUPDRVIDCHANDLE)ASMAtomicUoReadPtr((void * volatile *)&g_pMainHandle);
+    PSUPDRVIDCHANDLE pHandle = ASMAtomicUoReadPtrT(&g_pMainHandle, PSUPDRVIDCHANDLE);
     if (    VALID_PTR(pHandle)
         &&  pHandle->s.pSession == pSession)

trunk/src/VBox/HostDrivers/Support/SUPSvcGrant.cpp

@@ -179 +179 @@
      * Clean up the session.
      */
-    PSUPSVCGRANT pParent = (PSUPSVCGRANT)ASMAtomicReadPtr((void * volatile *)&pThis->pParent);
+    PSUPSVCGRANT pParent = ASMAtomicReadPtrT(&pThis->pParent, PSUPSVCGRANT);
     if (pParent)
         RTCritSectEnter(&pParent->CritSect);
@@ -975 +975 @@
     unsigned cSessions = 0;
     for (PSUPSVCGRANTSESSION pCur = pThis->pSessionHead; pCur; pCur = pCur->pNext)
-        ASMAtomicWritePtr((void * volatile *)&pCur->pParent, NULL);
+        ASMAtomicWritePtr(&pCur->pParent, NULL);
 
     RTCritSectLeave(&pThis->CritSect);