Changeset 30147 in vbox for trunk/src

Timestamp:

Jun 10, 2010 12:11:24 PM (15 years ago)

Author:

vboxsync

Message:

AsyncCompletion: Fix race in the failsafe manager when checking the woken up flag before going to sleep. The order matters here

File:

• trunk/src/VBox/VMM/PDMAsyncCompletionFileFailsafe.cpp (modified) (1 diff)

trunk/src/VBox/VMM/PDMAsyncCompletionFileFailsafe.cpp

@@ -118 +118 @@
            || (pAioMgr->enmState == PDMACEPFILEMGRSTATE_SUSPENDING))
     {
+        ASMAtomicWriteBool(&pAioMgr->fWaitingEventSem, true);
         if (!ASMAtomicReadBool(&pAioMgr->fWokenUp))
-        {
-            ASMAtomicWriteBool(&pAioMgr->fWaitingEventSem, true);
             rc = RTSemEventWait(pAioMgr->EventSem, RT_INDEFINITE_WAIT);
-            ASMAtomicWriteBool(&pAioMgr->fWaitingEventSem, false);
-            AssertRC(rc);
-        }
-        ASMAtomicXchgBool(&pAioMgr->fWokenUp, false);
+        ASMAtomicWriteBool(&pAioMgr->fWaitingEventSem, false);
+        AssertRC(rc);
+
+        LogFlow(("Got woken up\n"));
+        ASMAtomicWriteBool(&pAioMgr->fWokenUp, false);
 
         /* Process endpoint events first. */