Changeset 30304 in vbox for trunk

Timestamp:

Jun 18, 2010 10:51:15 AM (15 years ago)

Author:

vboxsync

Message:

Main: fixes to saveSettings and locking calls

Location:

trunk/src/VBox/Main

Files:

• HostImpl.cpp (modified) (3 diffs)
• MachineImpl.cpp (modified) (6 diffs)

trunk/src/VBox/Main/HostImpl.cpp

@@ -1145 +1145 @@
     /* save the global settings */
     alock.release();
+    AutoWriteLock vboxLock(m->pParent COMMA_LOCKVAL_SRC_POS);
     return rc = m->pParent->saveSettings();
 #else
@@ -1200 +1201 @@
     /* save the global settings */
     alock.release();
+    AutoWriteLock vboxLock(m->pParent COMMA_LOCKVAL_SRC_POS);
     return rc = m->pParent->saveSettings();
 #else
@@ -1763 +1765 @@
         // save the global settings... yeah, on every single filter property change
         alock.release();
+        AutoWriteLock vboxLock(m->pParent COMMA_LOCKVAL_SRC_POS);
         return m->pParent->saveSettings();
     }

trunk/src/VBox/Main/MachineImpl.cpp

@@ -3116 +3116 @@
         alock.leave();
 
-        rc = medium->createDiffStorage(diff, MediumVariant_Standard,
-                                       pMediumLockList, NULL /* aProgress */,
-                                       true /* aWait */, &fNeedsSaveSettings);
+        rc = medium->createDiffStorage(diff,
+                                       MediumVariant_Standard,
+                                       pMediumLockList,
+                                       NULL /* aProgress */,
+                                       true /* aWait */,
+                                       &fNeedsSaveSettings);
 
         alock.enter();
@@ -4872 +4875 @@
         return setError(VBOX_E_OBJECT_IN_USE, tr("CPU %lu is already attached"), aCpu);
 
-    alock.leave();
+    alock.release();
     rc = onCPUChange(aCpu, false);
-    alock.enter();
+    alock.acquire();
     if (FAILED(rc)) return rc;
 
@@ -4883 +4886 @@
     /* Save settings if online */
     if (Global::IsOnline(mData->mMachineState))
-        SaveSettings();
+        saveSettings();
 
     return S_OK;
@@ -4913 +4916 @@
         return setError(E_INVALIDARG, tr("It is not possible to detach CPU 0"));
 
-    alock.leave();
+    alock.release();
     rc = onCPUChange(aCpu, true);
-    alock.enter();
+    alock.acquire();
     if (FAILED(rc)) return rc;
 
@@ -4924 +4927 @@
     /* Save settings if online */
     if (Global::IsOnline(mData->mMachineState))
-        SaveSettings();
+        saveSettings();
 
     return S_OK;
@@ -11128 +11131 @@
             mData->mCurrentStateModified = TRUE;
             stsFlags |= SaveSTS_CurStateModified;
-            SaveSettings();
+            SaveSettings();     // @todo r=dj why the public method? why first SaveSettings and then saveStateSettings?
         }
     }