Changeset 30314 in vbox for trunk/src

Timestamp:

Jun 18, 2010 3:33:22 PM (15 years ago)

Author:

vboxsync

Message:

Main: fixes to saveSettings and locking calls, part 2

Location:

trunk/src/VBox/Main

Files:

• MediumImpl.cpp (modified) (2 diffs)
• VirtualBoxImpl.cpp (modified) (8 diffs)

trunk/src/VBox/Main/MediumImpl.cpp

@@ -5433 +5433 @@
     }
 
+    // deregister the task registered in createDiffStorage()
+    Assert(m->numCreateDiffTasks != 0);
+    --m->numCreateDiffTasks;
+
     if (task.isAsync())
     {
@@ -5446 +5450 @@
         if (task.m_pfNeedsSaveSettings)
             *task.m_pfNeedsSaveSettings = fNeedsSaveSettings;
-
-    /* deregister the task registered in createDiffStorage() */
-    Assert(m->numCreateDiffTasks != 0);
-    --m->numCreateDiffTasks;
 
     /* Note that in sync mode, it's the caller's responsibility to

trunk/src/VBox/Main/VirtualBoxImpl.cpp

@@ -3496 +3496 @@
 
 /**
- *  Helper function to write out the configuration tree.
+ *  Helper function which actually writes out VirtualBox.xml, the main configuration file.
+ *  Gets called from the public VirtualBox::SaveSettings() as well as from various other
+ *  places internally when settings need saving.
  *
  *  @note Caller must have locked the VirtualBox object for writing!
@@ -3569 +3571 @@
         settings::MediaList hardDisksTemp;
         for (MediaList::const_iterator it = m->ollHardDisks.begin();
-                it != m->ollHardDisks.end();
-                ++it)
+             it != m->ollHardDisks.end();
+             ++it)
         {
             settings::Medium med;
@@ -3581 +3583 @@
         settings::MediaList dvdsTemp;
         for (MediaList::const_iterator it = m->ollDVDImages.begin();
-                it != m->ollDVDImages.end();
-                ++it)
+             it != m->ollDVDImages.end();
+             ++it)
         {
             settings::Medium med;
@@ -3593 +3595 @@
         settings::MediaList floppiesTemp;
         for (MediaList::const_iterator it = m->ollFloppyImages.begin();
-                it != m->ollFloppyImages.end();
-                ++it)
+             it != m->ollFloppyImages.end();
+             ++it)
         {
             settings::Medium med;
@@ -4588 +4590 @@
         {
             listeners.Add(*pp);
-        }                   
-#endif  
+        }
+#endif
     }
 
@@ -4613 +4615 @@
 
         /**
-         * Would be just handleCallback(cbI) in an ideal world, unfortunately our 
+         * Would be just handleCallback(cbI) in an ideal world, unfortunately our
          * consumers want to be invoked via IDispatch, thus going the hard way.
          */
@@ -4769 +4771 @@
     if (aSaveRegistry)
     {
+        AutoWriteLock vboxLock(this COMMA_LOCKVAL_SRC_POS);
         rc = saveSettings();
+        vboxLock.release();
+
         if (FAILED(rc))
             unregisterDHCPServer(aDHCPServer, false /* aSaveRegistry */);
@@ -4811 +4816 @@
     if (aSaveRegistry)
     {
+        AutoWriteLock vboxLock(this COMMA_LOCKVAL_SRC_POS);
         rc = saveSettings();
+        vboxLock.release();
+
         if (FAILED(rc))
             registerDHCPServer(aDHCPServer, false /* aSaveRegistry */);