Changeset 30328 in vbox

Timestamp:

Jun 21, 2010 12:55:14 PM (15 years ago)

Author:

vboxsync

Message:

More paranoia

File:

• trunk/src/VBox/VMM/VMMAll/PDMAllCritSect.cpp (modified) (7 diffs)

trunk/src/VBox/VMM/VMMAll/PDMAllCritSect.cpp

@@ -91 +91 @@
 
     ASMAtomicWriteS32(&pCritSect->s.Core.cNestings, 1);
+    Assert(pCritSect->s.Core.cNestings == 1);
     ASMAtomicWriteHandle(&pCritSect->s.Core.NativeThreadOwner, hNativeSelf);
 
@@ -171 +172 @@
 {
     Assert(pCritSect->s.Core.cNestings < 8);  /* useful to catch incorrect locking */
+    Assert(pCritSect->s.Core.cNestings >= 0);
 
     /*
@@ -192 +194 @@
         ASMAtomicIncS32(&pCritSect->s.Core.cLockers);
         ASMAtomicIncS32(&pCritSect->s.Core.cNestings);
+        Assert(pCritSect->s.Core.cNestings > 1);
         ASMAtomicAndU32(&pCritSect->s.Core.fFlags, ~PDMCRITSECT_FLAGS_PENDING_UNLOCK);
         return VINF_SUCCESS;
@@ -313 +316 @@
         ASMAtomicIncS32(&pCritSect->s.Core.cLockers);
         ASMAtomicIncS32(&pCritSect->s.Core.cNestings);
+        Assert(pCritSect->s.Core.cNestings > 1);
         ASMAtomicAndU32(&pCritSect->s.Core.fFlags, ~PDMCRITSECT_FLAGS_PENDING_UNLOCK);
         return VINF_SUCCESS;
@@ -423 +427 @@
     {
         ASMAtomicDecS32(&pCritSect->s.Core.cNestings);
+        Assert(pCritSect->s.Core.cNestings >= 1);
         ASMAtomicDecS32(&pCritSect->s.Core.cLockers);
         return;
@@ -452 +457 @@
         ASMAtomicWriteHandle(&pCritSect->s.Core.NativeThreadOwner, NIL_RTNATIVETHREAD);
         ASMAtomicDecS32(&pCritSect->s.Core.cNestings);
+        Assert(pCritSect->s.Core.cNestings == 0);
 
         /* stop and decrement lockers. */
@@ -502 +508 @@
             ASMAtomicWriteHandle(&pCritSect->s.Core.NativeThreadOwner, hNativeThread);
             STAM_PROFILE_ADV_START(&pCritSect->s.StatLocked, l);
+            Assert(pCritSect->s.Core.cNestings == 0);
             ASMAtomicWriteS32(&pCritSect->s.Core.cNestings, 1);
         }