Changeset 30342 in vbox

Timestamp:

Jun 21, 2010 4:24:57 PM (14 years ago)

Author:

vboxsync

Message:

VMM: todo: Use NIL_VMCPUID with two SUPR3CallVMMR0Ex calls?

Location:

trunk/src/VBox/VMM

Files:

• GMM.cpp (modified) (1 diff)
• PGMPhys.cpp (modified) (1 diff)

trunk/src/VBox/VMM/GMM.cpp

@@ -306 +306 @@
 
     /* Must be callable from any thread, so can't use VMMR3CallR0. */
+    /** @todo Shouldn't we use NIL_VMCPUID here?  */
     int rc = SUPR3CallVMMR0Ex(pVM->pVMR0, 0, VMMR0_DO_GMM_QUERY_HYPERVISOR_MEM_STATS, 0, &Req.Hdr);
     if (rc == VINF_SUCCESS)

trunk/src/VBox/VMM/PGMPhys.cpp

@@ -3387 +3387 @@
 
     /* Must be callable from any thread, so can't use VMMR3CallR0. */
+    /** @todo r=bird: Why must it be a valid one? NIL_VMCPUID should do the
+     *        trick as it does a bunch of other places, shouldn't it? */
     rc = SUPR3CallVMMR0Ex(pVM->pVMR0, 0 /* use CPU id 0; it must be a valid one */, VMMR0_DO_GMM_MAP_UNMAP_CHUNK, 0, &Req.Hdr);
     if (RT_SUCCESS(rc))