Changeset 30403 in vbox

Timestamp:

Jun 23, 2010 6:42:17 PM (15 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

63023

Message:

VBoxManage: Fix crash when changing the I/O cache option for a non existant controller

File:

• trunk/src/VBox/Frontends/VBoxManage/VBoxManageStorageController.cpp (modified) (1 diff)

trunk/src/VBox/Frontends/VBoxManage/VBoxManageStorageController.cpp

@@ -929 +929 @@
             CHECK_ERROR(machine, GetStorageControllerByName(Bstr(pszCtl), ctl.asOutParam()));
 
-            if (!RTStrICmp(pszHostIOCache, "on"))
-            {
-                CHECK_ERROR(ctl, COMSETTER(UseHostIOCache)(TRUE));
-            }
-            else if (!RTStrICmp(pszHostIOCache, "off"))
-            {
-                CHECK_ERROR(ctl, COMSETTER(UseHostIOCache)(FALSE));
-            }
-            else
-            {
-                errorArgument("Invalid --hostiocache argument '%s'", pszHostIOCache);
+            if (SUCCEEDED(rc))
+            {
+                if (!RTStrICmp(pszHostIOCache, "on"))
+                {
+                    CHECK_ERROR(ctl, COMSETTER(UseHostIOCache)(TRUE));
+                }
+                else if (!RTStrICmp(pszHostIOCache, "off"))
+                {
+                    CHECK_ERROR(ctl, COMSETTER(UseHostIOCache)(FALSE));
+                }
+                else
+                {
+                    errorArgument("Invalid --hostiocache argument '%s'", pszHostIOCache);
+                    rc = E_FAIL;
+                }
+            }
+            else
+            {
+                errorArgument("Couldn't find the controller with the name: '%s'\n", pszCtl);
                 rc = E_FAIL;
             }