Changeset 30415 in vbox for trunk/src/VBox

Timestamp:

Jun 24, 2010 9:02:31 AM (15 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

63044

Message:

NAT: comments

File:

• trunk/src/VBox/Devices/Network/slirp/ip_icmp.c (modified) (8 diffs)

trunk/src/VBox/Devices/Network/slirp/ip_icmp.c

@@ -61 +61 @@
 #endif
 
-#ifdef RT_OS_WINDOWS
-# define ICMP_SEND_ECHO(event, routine, addr, data, datasize, ipopt)                                        \
-                IcmpSendEcho2(pData->icmp_socket.sh, (event), NULL, NULL, (addr), (data), (datasize),       \
-                               (ipopt), pData->pvIcmpBuffer, pData->szIcmpBuffer, 1)
-#endif /* RT_OS_WINDOWS */
-
 /* The message sent when emulating PING */
 /* Be nice and tell them it's just a psuedo-ping packet */
@@ -355 +349 @@
         /* min 8 bytes payload */
         icmpstat.icps_tooshort++;
-        goto end_error;
+        goto end_error_free_m;
     }
 
@@ -364 +358 @@
     {
         icmpstat.icps_checksum++;
-        goto end_error;
+        goto end_error_free_m;
     }
 
@@ -373 +367 @@
         {
             LogRel(("NAT: not enought memory to allocate the buffer\n"));
-            goto end_error;
+            goto end_error_free_m;
         }
         m_copydata(m, 0, icmplen, icp_buf);
@@ -443 +437 @@
                         goto done;
                     }
-                    
+
                     LogRel((dfd,"icmp_input udp sendto tx errno = %d-%s\n",
                                 errno, strerror(errno)));
@@ -454 +448 @@
                 memset(&ipopt, 0, sizeof(IP_OPTION_INFORMATION));
                 ipopt.Ttl = ip->ip_ttl;
-                status = ICMP_SEND_ECHO(pData->phEvents[VBOX_ICMP_EVENT_INDEX], notify_slirp, addr.sin_addr.s_addr,
-                                icp->icmp_data, icmplen - ICMP_MINLEN, &ipopt);
+                status = IcmpSendEcho2(pData->icmp_socket.sh /*=handle*/,
+                                       pData->phEvents[VBOX_ICMP_EVENT_INDEX] /*=Event*/,
+                                       NULL /*=ApcRoutine*/,
+                                       NULL /*=ApcContext*/,
+                                       addr.sin_addr.s_addr /*=DestinationAddress*/,
+                                       icp->icmp_data /*=RequestData*/,
+                                       icmplen - ICMP_MINLEN /*=RequestSize*/,
+                                       &ipopt /*=RequestOptions*/,
+                                       pData->pvIcmpBuffer /*=ReplyBuffer*/,
+                                       pData->szIcmpBuffer /*=ReplySize*/,
+                                       1 /*=Timeout in ms*/);
                 error = GetLastError();
-                if (   status != 0 
+                if (   status != 0
                     || error == ERROR_IO_PENDING)
                 {
+                    /* no error! */
                     m->m_so = &pData->icmp_socket;
                     icmp_attach(pData, m);
@@ -489 +493 @@
         case ICMP_UNREACH:
         case ICMP_TIMXCEED:
-            /* @todo(vvl): both up cases comes from guest, 
-             *  indeed right solution would be find the socket 
-             *  corresponding to ICMP data and close it.  
+            /* @todo(vvl): both up cases comes from guest,
+             *  indeed right solution would be find the socket
+             *  corresponding to ICMP data and close it.
              */
         case ICMP_PARAMPROB:
@@ -504 +508 @@
             icmpstat.icps_badtype++;
     } /* switch */
-    
-end_error:
+
+end_error_free_m:
     m_freem(pData, m);