Changeset 30488 in vbox

Timestamp:

Jun 29, 2010 9:02:04 AM (15 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

63179

Message:

Debug code to find duplicate pages

Location:

trunk

Files:

• include/VBox/gmm.h (modified) (3 diffs)
• include/VBox/pci.h (modified) (2 diffs)
• include/VBox/vmm.h (modified) (1 diff)
• src/VBox/VMM/GMM.cpp (modified) (1 diff)
• src/VBox/VMM/PGM.cpp (modified) (3 diffs)
• src/VBox/VMM/VMMR0/GMMR0.cpp (modified) (1 diff)
• src/VBox/VMM/VMMR0/VMMR0.cpp (modified) (1 diff)

trunk/include/VBox/gmm.h

@@ -306 +306 @@
 #endif
 
-
 /**
  * Request buffer for GMMR0InitialReservationReq / VMMR0_DO_GMM_INITIAL_RESERVATION.
@@ -588 +587 @@
 GMMR0DECL(int) GMMR0UnregisterSharedModuleReq(PVM pVM, VMCPUID idCpu, PGMMUNREGISTERSHAREDMODULEREQ pReq);
 
+#if defined(VBOX_STRICT) && HC_ARCH_BITS == 64
+/**
+ * Request buffer for GMMR0FindDuplicatePageReq / VMMR0_DO_GMM_FIND_DUPLICATE_PAGE.
+ * @see GMMR0FindDuplicatePage.
+ */
+typedef struct GMMFINDDUPLICATEPAGEREQ
+{
+    /** The header. */
+    SUPVMMR0REQHDR              Hdr;
+    /** Page id. */
+    uint32_t                    idPage;
+    /** Duplicate flag (out) */
+    bool                        fDuplicate;
+} GMMFINDDUPLICATEPAGEREQ;
+/** Pointer to a GMMR0FindDuplicatePageReq / VMMR0_DO_GMM_FIND_DUPLICATE_PAGE request buffer. */
+typedef GMMFINDDUPLICATEPAGEREQ *PGMMFINDDUPLICATEPAGEREQ;
+
+GMMR0DECL(int) GMMR0FindDuplicatePageReq(PVM pVM, PGMMFINDDUPLICATEPAGEREQ pReq);
+#endif /* VBOX_STRICT && HC_ARCH_BITS == 64 */
 
 #ifdef IN_RING3
@@ -616 +634 @@
 GMMR3DECL(int)  GMMR3CheckSharedModules(PVM pVM);
 GMMR3DECL(int)  GMMR3ResetSharedModules(PVM pVM);
+
+# if defined(VBOX_STRICT) && HC_ARCH_BITS == 64
+GMMR3DECL(bool) GMMR3IsDuplicatePage(PVM pVM, uint32_t idPage);
+# endif
+
 /** @} */
 #endif /* IN_RING3 */

trunk/include/VBox/pci.h

@@ -462 +462 @@
 }
 
+/**
+ * Gets the interrupt line config register.
+ *
+ * @returns The interrupt line.
+ * @param   pPciDev         The PCI device.
+ */
+DECLINLINE(uint8_t) PCIDevGetInterruptLine(PPCIDEVICE pPciDev)
+{
+    return pPciDev->config[VBOX_PCI_INTERRUPT_LINE];
+}
 
 /**
@@ -475 +485 @@
 
 
+/**
+ * Gets the interrupt pin config register.
+ *
+ * @returns The interrupt pin.
+ * @param   pPciDev         The PCI device.
+ */
+DECLINLINE(uint8_t) PCIDevGetInterruptPin(PPCIDEVICE pPciDev)
+{
+    return pPciDev->config[VBOX_PCI_INTERRUPT_PIN];
+}
+
+
 /** @} */
 
 #endif
+

trunk/include/VBox/vmm.h

@@ -312 +312 @@
     /** Call GMMR0CheckSharedModules. */
     VMMR0_DO_GMM_CHECK_SHARED_MODULES,
+    /** Call GMMR0FindDuplicatePage. */
+    VMMR0_DO_GMM_FIND_DUPLICATE_PAGE,
 
     /** Set a GVMM or GMM configuration value. */

trunk/src/VBox/VMM/GMM.cpp

@@ -419 +419 @@
     return VMMR3CallR0(pVM, VMMR0_DO_GMM_CHECK_SHARED_MODULES, 0, NULL);
 }
+
+#if defined(VBOX_STRICT) && HC_ARCH_BITS == 64
+/**
+ * @see GMMR0FindDuplicatePage
+ */
+GMMR3DECL(bool) GMMR3IsDuplicatePage(PVM pVM, uint32_t idPage)
+{
+    GMMFINDDUPLICATEPAGEREQ Req;
+    Req.Hdr.u32Magic = SUPVMMR0REQHDR_MAGIC;
+    Req.Hdr.cbReq    = sizeof(Req);
+    Req.idPage       = idPage;
+    Req.fDuplicate   = false;
+
+    int rc = VMMR3CallR0(pVM, VMMR0_DO_GMM_FIND_DUPLICATE_PAGE, 0, &Req.Hdr);
+    if (rc == VINF_SUCCESS)
+        return Req.fDuplicate;
+    else
+        return false;
+}
+#endif /* VBOX_STRICT && HC_ARCH_BITS == 64 */
+

trunk/src/VBox/VMM/PGM.cpp

@@ -641 +641 @@
 static DECLCALLBACK(int)  pgmR3CmdAssertCR3(PCDBGCCMD pCmd, PDBGCCMDHLP pCmdHlp, PVM pVM, PCDBGCVAR paArgs, unsigned cArgs, PDBGCVAR pResult);
 # endif
+# if defined(VBOX_STRICT) && HC_ARCH_BITS == 64
+static DECLCALLBACK(int)  pgmR3CmdCheckDuplicatePages(PCDBGCCMD pCmd, PDBGCCMDHLP pCmdHlp, PVM pVM, PCDBGCVAR paArgs, unsigned cArgs, PDBGCVAR pResult);
+# endif
 static DECLCALLBACK(int)  pgmR3CmdPhysToFile(PCDBGCCMD pCmd, PDBGCCMDHLP pCmdHlp, PVM pVM, PCDBGCVAR paArgs, unsigned cArgs, PDBGCVAR pResult);
 #endif
@@ -673 +676 @@
 #ifdef VBOX_STRICT
     { "pgmassertcr3",  0, 0,        NULL,                     0,            NULL,               0,          pgmR3CmdAssertCR3,  "",                     "Check the shadow CR3 mapping." },
+#endif
+#if defined(VBOX_STRICT) && HC_ARCH_BITS == 64
+    { "pgmcheckduppages", 0, 0,     NULL,                     0,            NULL,               0,          pgmR3CmdCheckDuplicatePages,  "",           "Check for duplicate pages in all running VMs." },
 #endif
     { "pgmsyncalways", 0, 0,        NULL,                     0,            NULL,               0,          pgmR3CmdSyncAlways, "",                     "Toggle permanent CR3 syncing." },
@@ -4156 +4162 @@
 #endif /* VBOX_STRICT */
 
+#if defined(VBOX_STRICT) && HC_ARCH_BITS == 64
+/**
+ * The '.pgmcheckduppages' command.
+ *
+ * @returns VBox status.
+ * @param   pCmd        Pointer to the command descriptor (as registered).
+ * @param   pCmdHlp     Pointer to command helper functions.
+ * @param   pVM         Pointer to the current VM (if any).
+ * @param   paArgs      Pointer to (readonly) array of arguments.
+ * @param   cArgs       Number of arguments in the array.
+ */
+static DECLCALLBACK(int)  pgmR3CmdCheckDuplicatePages(PCDBGCCMD pCmd, PDBGCCMDHLP pCmdHlp, PVM pVM, PCDBGCVAR paArgs, unsigned cArgs, PDBGCVAR pResult)
+{
+    unsigned cBallooned = 0;
+    unsigned cShared = 0;
+    unsigned cZero = 0;
+    unsigned cUnique = 0;
+    unsigned cDuplicate = 0;
+
+    pgmLock(pVM);
+
+    for (PPGMRAMRANGE pRam = pVM->pgm.s.pRamRangesR3; pRam; pRam = pRam->pNextR3)
+    {
+        PPGMPAGE    pPage  = &pRam->aPages[0];
+        RTGCPHYS    GCPhys = pRam->GCPhys;
+        uint32_t    cLeft  = pRam->cb >> PAGE_SHIFT;
+        while (cLeft-- > 0)
+        {
+            if (PGM_PAGE_GET_TYPE(pPage) == PGMPAGETYPE_RAM)
+            {
+                switch (PGM_PAGE_GET_STATE(pPage))
+                {
+                    case PGM_PAGE_STATE_ZERO:
+                        cZero++;
+                        break;
+
+                    case PGM_PAGE_STATE_BALLOONED:
+                        cBallooned++;
+                        break;
+
+                    case PGM_PAGE_STATE_SHARED:
+                        cShared++;
+                        break;
+
+                    case PGM_PAGE_STATE_ALLOCATED:
+                    case PGM_PAGE_STATE_WRITE_MONITORED:
+                        if (GMMR3IsDuplicatePage(pVM, PGM_PAGE_GET_PAGEID(pPage)))
+                            cDuplicate++;
+                        else
+                            cUnique++;
+
+                        break;
+
+                    default:
+                        AssertFailed();
+                        break;
+                }
+            }
+
+            /* next */
+            pPage++;
+            GCPhys += PAGE_SIZE;
+        }
+    }
+    pgmUnlock(pVM);
+
+    pCmdHlp->pfnPrintf(pCmdHlp, NULL, "Number of zero pages      %x\n", cZero);
+    pCmdHlp->pfnPrintf(pCmdHlp, NULL, "Number of ballooned pages %x\n", cBallooned);
+    pCmdHlp->pfnPrintf(pCmdHlp, NULL, "Number of shared pages    %x\n", cShared);
+    pCmdHlp->pfnPrintf(pCmdHlp, NULL, "Number of unique pages    %x\n", cUnique);
+    pCmdHlp->pfnPrintf(pCmdHlp, NULL, "Number of duplicate pages %x\n", cDuplicate);
+    return VINF_SUCCESS;
+}
+
+#endif /* VBOX_STRICT && HC_ARCH_BITS == 64*/
+
 
 /**

trunk/src/VBox/VMM/VMMR0/GMMR0.cpp

@@ -4189 +4189 @@
 #endif
 }
+
+#if defined(VBOX_STRICT) && HC_ARCH_BITS == 64
+typedef struct
+{
+    PGVM                    pGVM;
+    PGMM                    pGMM;
+    uint8_t                *pSourcePage;
+    bool                    fFoundDuplicate;
+} GMMFINDDUPPAGEINFO, *PGMMFINDDUPPAGEINFO;
+
+/**
+ * RTAvlU32DoWithAll callback.
+ *
+ * @returns 0
+ * @param   pNode   The node to search.
+ * @param   pvInfo  Pointer to the input parameters
+ */
+static DECLCALLBACK(int) gmmR0FindDupPageInChunk(PAVLU32NODECORE pNode, void *pvInfo)
+{
+    PGMMCHUNK           pChunk = (PGMMCHUNK)pNode;
+    PGMMFINDDUPPAGEINFO pInfo = (PGMMFINDDUPPAGEINFO)pvInfo;
+    PGVM                pGVM = pInfo->pGVM;
+    PGMM                pGMM = pInfo->pGMM;
+    uint8_t            *pbChunk;
+
+    /* Only take chunks not mapped into this VM process; not entirely correct. */
+    if (!gmmR0IsChunkMapped(pGVM, pChunk, (PRTR3PTR)&pbChunk))
+    {
+        int rc = gmmR0MapChunk(pGMM, pGVM, pChunk, (PRTR3PTR)&pbChunk);
+        if (rc != VINF_SUCCESS)
+            goto end;
+
+        /*
+         * Look for duplicate pages
+         */
+        unsigned iPage = (GMM_CHUNK_SIZE >> PAGE_SHIFT);
+        while (iPage-- > 0)
+        {
+            if (GMM_PAGE_IS_PRIVATE(&pChunk->aPages[iPage]))
+            {
+                uint8_t *pbDestPage = pbChunk + (iPage  << PAGE_SHIFT);
+
+                if (!memcmp(pInfo->pSourcePage, pbDestPage, PAGE_SIZE))
+                {
+                    pInfo->fFoundDuplicate = true;
+                    break;
+                }
+            }
+        }
+        gmmR0UnmapChunk(pGMM, pGVM, pChunk);
+    }
+end:
+    if (pInfo->fFoundDuplicate)
+        return 1;   /* stop search */
+    else
+        return 0;
+}
+
+/**
+ * Find a duplicate of the specified page in other active VMs
+ *
+ * @returns VBox status code.
+ * @param   pVM                 VM handle
+ * @param   pReq                Request packet
+ */
+GMMR0DECL(int) GMMR0FindDuplicatePageReq(PVM pVM, PGMMFINDDUPLICATEPAGEREQ pReq)
+{
+    /*
+     * Validate input and pass it on.
+     */
+    AssertPtrReturn(pVM, VERR_INVALID_POINTER);
+    AssertPtrReturn(pReq, VERR_INVALID_POINTER);
+    AssertMsgReturn(pReq->Hdr.cbReq == sizeof(*pReq), ("%#x != %#x\n", pReq->Hdr.cbReq, sizeof(*pReq)), VERR_INVALID_PARAMETER);
+
+    PGMM pGMM;
+    GMM_GET_VALID_INSTANCE(pGMM, VERR_INTERNAL_ERROR);
+
+    /*
+     * Take the sempahore and do some more validations.
+     */
+    int rc = RTSemFastMutexRequest(pGMM->Mtx);
+    AssertRC(rc);
+    if (GMM_CHECK_SANITY_UPON_ENTERING(pGMM))
+    {
+        PGVM pGVM;
+        rc = GVMMR0ByVM(pVM, &pGVM);
+        if (RT_FAILURE(rc))
+            goto end;
+
+        uint8_t  *pbChunk;
+        PGMMCHUNK pChunk = gmmR0GetChunk(pGMM, pReq->idPage >> GMM_CHUNKID_SHIFT);
+        if (!pChunk)
+        {
+            AssertFailed();
+            goto end;
+        }
+
+        if (!gmmR0IsChunkMapped(pGVM, pChunk, (PRTR3PTR)&pbChunk))
+        {
+            AssertFailed();
+            goto end;
+        }
+
+        uint8_t *pbSourcePage = pbChunk + ((pReq->idPage & GMM_PAGEID_IDX_MASK) << PAGE_SHIFT);
+
+        PGMMPAGE pPage = gmmR0GetPage(pGMM, pReq->idPage);
+        if (!pPage)
+        {
+            AssertFailed();
+            rc = VERR_PGM_PHYS_INVALID_PAGE_ID;
+            goto end;
+        }
+        GMMFINDDUPPAGEINFO Info;
+
+        Info.pGVM            = pGVM;
+        Info.pGMM            = pGMM;
+        Info.pSourcePage     = pbSourcePage;
+        Info.fFoundDuplicate = false;
+        RTAvlU32DoWithAll(&pGMM->pChunks, true /* fFromLeft */, gmmR0FindDupPageInChunk, pGVM);
+
+        pReq->fDuplicate = Info.fFoundDuplicate;
+    }
+    else
+        rc = VERR_INTERNAL_ERROR_5;
+
+end:
+    RTSemFastMutexRelease(pGMM->Mtx);
+    return rc;
+}
+
+#endif /* VBOX_STRICT && HC_ARCH_BITS == 64 */
+

trunk/src/VBox/VMM/VMMR0/VMMR0.cpp

@@ -986 +986 @@
 #endif
 
+#if defined(VBOX_STRICT) && HC_ARCH_BITS == 64
+        case VMMR0_DO_GMM_FIND_DUPLICATE_PAGE:
+        {
+            if (u64Arg)
+                return VERR_INVALID_PARAMETER;
+            return GMMR0FindDuplicatePageReq(pVM, (PGMMFINDDUPLICATEPAGEREQ)pReqHdr);
+        }
+#endif
+
         /*
          * A quick GCFGM mock-up.