Changeset 30591 in vbox

Timestamp:

Jul 2, 2010 6:41:57 PM (15 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

63316

Message:

Main: events bits

Location:

trunk/src/VBox/Main

Files:

• ConsoleImpl.cpp (modified) (4 diffs)
• EventImpl.cpp (modified) (2 diffs)
• VirtualBoxImpl.cpp (modified) (1 diff)
• glue/tests/TestVBox.java (modified) (3 diffs)

trunk/src/VBox/Main/ConsoleImpl.cpp

@@ -4976 +4976 @@
         }
         evDesc.init(mEventSource, VBoxEventType_OnCanShowWindow);
-        BOOL fDelivered = evDesc.fire(10000); /* Wait up to 10 secs for delivery */
-        Assert(fDelivered);
+        BOOL fDelivered = evDesc.fire(5000); /* Wait up to 5 secs for delivery */
+        //Assert(fDelivered);
         if (fDelivered)
         {
@@ -4997 +4997 @@
         }
         else
-        {
-            Assert(FALSE);
             *aCanShow = TRUE;
-        }
     }
     else
@@ -5027 +5024 @@
             ++it;
         }
-#if 1
         evDesc.init(mEventSource, VBoxEventType_OnShowWindow, UINT64_C(0));
-        ComPtr<IEvent> aEvent;
-        evDesc.getEvent(aEvent.asOutParam());
-        ComPtr<IShowWindowEvent> aShowEvent = aEvent;
-
-        BOOL fDelivered = evDesc.fire(10000); /* Wait up to 10 secs for delivery */
-        Assert(fDelivered);
+        BOOL fDelivered = evDesc.fire(5000); /* Wait up to 5 secs for delivery */
+        //Assert(fDelivered);
         if (fDelivered)
         {
+            ComPtr<IEvent> aEvent;
+            evDesc.getEvent(aEvent.asOutParam());
+            ComPtr<IShowWindowEvent> aShowEvent = aEvent;
             ULONG64 aEvWinId = 0;
             if (aShowEvent)
             {
                 aShowEvent->COMGETTER(WinId)(&aEvWinId);
-                if (aEvWinId != 0)
+                if ((aEvWinId != 0) && (*aWinId == 0))
                     *aWinId = aEvWinId;
             }
@@ -5047 +5042 @@
                 Assert(FALSE);
         }
-        else
-            Assert(FALSE);
- #endif
     }
 

trunk/src/VBox/Main/EventImpl.cpp

@@ -357 +357 @@
         return mActive;
     }
+
+    friend class EventSource;
 };
 
@@ -736 +738 @@
              */
             cbRc = record.obj()->process(aEvent, aWaitable, pit, alock);
-            // what to do with cbRc?
+
+            if (FAILED_DEAD_INTERFACE(cbRc))
+            {
+                AutoWriteLock awlock(this COMMA_LOCKVAL_SRC_POS);
+                Listeners::iterator lit = m->mListeners.find(record.obj()->mListener);
+                if (lit != m->mListeners.end())
+                    m->mListeners.erase(lit);
+            }
+            // anything else to do with cbRc?
         }
     } while (0);

trunk/src/VBox/Main/VirtualBoxImpl.cpp

@@ -2752 +2752 @@
     VBoxEventDesc evDesc;
     evDesc.init(m->pEventSource, VBoxEventType_OnExtraDataCanChange, id.raw(), aKey, aValue);
-    BOOL fDelivered = evDesc.fire(10000); /* Wait up to 10 secs for delivery */
-    Assert(fDelivered);
+    BOOL fDelivered = evDesc.fire(3000); /* Wait up to 3 secs for delivery */
+    //Assert(fDelivered);
     if (fDelivered)
     {

trunk/src/VBox/Main/glue/tests/TestVBox.java

@@ -207 +207 @@
     }
 
-    static void testEvents(VirtualBoxManager mgr, IEventSource es)
-    {
-        IEventListener listener = es.createListener();
+    static class EventHandler
+    {
+        EventHandler() {}
+        public void handleEvent(IEvent ev)
+        {
+            try {
+                processEvent(ev);
+            } catch (Throwable t) {
+                t.printStackTrace();
+            }
+        }
+    }
+
+    static void testEvents(VirtualBoxManager mgr, IEventSource es, boolean active)
+    {
+        // active mode for Java doesn't fully work yet, and using passive
+        // is more portable (the only mode for MSCOM and WS) and thus generally 
+        // recommended
+        IEventListener listener = active ? mgr.createListener(new EventHandler()) : es.createListener();
 
         es.registerListener(listener, Arrays.asList(VBoxEventType.Any), false);
@@ -216 +232 @@
             for (int i=0; i<100; i++)
             {
-                IEvent ev = es.getEvent(listener, 1000);
                 System.out.print(".");
-                if (ev != null)
+                if (active)
                 {
-                    processEvent(ev);
-                    es.eventProcessed(listener, ev);
+                    mgr.waitForEvents(500);
+                }
+                else
+                {
+                    IEvent ev = es.getEvent(listener, 1000);
+                    if (ev != null)
+                    {
+                        processEvent(ev);
+                        es.eventProcessed(listener, ev);
+                    }
                 }
             }
@@ -263 +286 @@
             testStart(mgr, vbox);
             //testCallbacks(mgr, vbox);
-            testEvents(mgr, vbox.getEventSource());
+            testEvents(mgr, vbox.getEventSource(), false);
 
             System.out.println("done, press Enter...");