Changeset 30611 in vbox

Timestamp:

Jul 5, 2010 12:53:59 PM (15 years ago)

Author:

vboxsync

Message:

strspace.cpp: Fixed bug in sdbm() resulting in wrong cchString values (+1). Return true when inserting into the collision list, only return false for identical strings.

File:

• trunk/src/VBox/Runtime/common/string/strspace.cpp (modified) (3 diffs)

trunk/src/VBox/Runtime/common/string/strspace.cpp

@@ -84 +84 @@
    this is one of the algorithms used in berkeley db (see sleepycat) and
    elsewhere. */
-inline uint32_t sdbm(const char *str, size_t *pcch)
+DECLINLINE(uint32_t) sdbm(const char *str, size_t *pcch)
 {
     uint8_t *pu8 = (uint8_t *)str;
@@ -93 +93 @@
         hash = c + (hash << 6) + (hash << 16) - hash;
 
-    *pcch = (uintptr_t)pu8 - (uintptr_t)str;
+    *pcch = (uintptr_t)pu8 - (uintptr_t)str - 1;
     return hash;
 }
@@ -120 +120 @@
     pStr->pList = pMatch->pList;
     pMatch->pList = pStr;
-    return false;
+    return true;
 }
 RT_EXPORT_SYMBOL(RTStrSpaceInsert);