Changeset 30706 in vbox

Timestamp:

Jul 7, 2010 1:51:37 PM (15 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

63470

Message:

Main: simple locking

File:

• trunk/src/VBox/Main/EventImpl.cpp (modified) (3 diffs)

trunk/src/VBox/Main/EventImpl.cpp

@@ -771 +771 @@
 
     do {
-        /* See comment in EventSource::GetEvent() */
-        AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
+        AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
 
         VBoxEventType_T evType;
@@ -813 +812 @@
             if (FAILED_DEAD_INTERFACE(cbRc))
             {
-                AutoWriteLock awlock(this COMMA_LOCKVAL_SRC_POS);
                 Listeners::iterator lit = m->mListeners.find(record.obj()->mListener);
                 if (lit != m->mListeners.end())
@@ -842 +840 @@
     if (FAILED(autoCaller.rc())) return autoCaller.rc();
 
-    /**
-     * There's subtle dependency between this lock and one in FireEvent():
-     * we need to be able to access event queue in FireEvent() while waiting
-     * here, to make this wait preemptible, thus both take read lock (write
-     * lock in FireEvent() would do too, and probably is a bit stricter),
-     * but will be unable to .
-     */
     AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);