Changeset 3078 in vbox for trunk

Timestamp:

Jun 7, 2007 4:18:31 PM (18 years ago)

Author:

vboxsync

Message:

1859: FE/Qt Mouse cursor issue:

Fix for the issue #1:
VBoxDefs::ResizeEventType event appears in case of guest video sub-system was changed for somehow even without video resolution change. In this last case the host VM window will not be resized according this event and the host mouse cursor which was unset to "default" here will not be hidden in capture state. So it is necessary to perform updateMouseClipping() for the guest resize event if the mouse cursor was captured before.

Fix for the issue #3:
When we are entering mouse integration mode we have to notify the guest system about it to make sure the guest will hide it’s cursor to let using of host's cursor for the guest mouse manipulation. This is not possible for the current API. That is why we have two cursors displayed one-above-one at the entering mouse integration mode. So we have to temporary hide host cursor and wait until guest hide it’s cursor and send a message about shape change to the host.

File:

• trunk/src/VBox/Frontends/VirtualBox/src/VBoxConsoleView.cpp (modified) (2 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/VBoxConsoleView.cpp

@@ -819 +819 @@
         captureMouse (!enabled, false);
 
+    /* Hiding host cursor in case we are entering mouse integration
+     * mode until it's shape is set to the guest cursor shape in
+     * OnMousePointerShapeChange event handler.
+     *
+     * This is necessary to avoid double-cursor issue when both the
+     * guest and the host cursors are displayed in one place one-above-one.
+     *
+     * This is a workaround because the correct decision is to notify
+     * the Guest Additions about we are entering the mouse integration
+     * mode. The GuestOS should hide it's cursor to allow using of
+     * host cursor for the guest's manipulation.
+     *
+     * This notification is not possible right now due to there is
+     * no the required API. */
+    if (enabled)
+        viewport()->setCursor (QCursor (BlankCursor));
+
     mouse_integration = enabled;
 
@@ -893 +910 @@
                 fb->resizeEvent (re);
                 viewport()->unsetCursor();
+
+                /* This event appears in case of guest video was changed
+                 * for somehow even without video resolution change.
+                 * In this last case the host VM window will not be resized
+                 * according this event and the host mouse cursor which was
+                 * unset to default here will not be hidden in capture state.
+                 * So it is necessary to perform updateMouseClipping() for
+                 * the guest resize event if the mouse cursor was captured. */
+                if (mouse_captured)
+                    updateMouseClipping();
 
                 /* apply maximum size restriction */